Virtualize Log component with scrollback limits and infinite scroll#1
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Virtualize Log component with scrollback limits and infinite scroll#1devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- Set xterm scrollback buffer limit to 5000 lines to cap memory usage - Add scroll-to-top detection to fetch older logs from Redis in batches of 200 - Track earliest stream ID for pagination via refs - Add proper socket cleanup on unmount - Remove unused Line import and response state - Memoize callbacks with useCallback to prevent unnecessary re-renders Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Virtualizes the React
Logcomponent by configuring xterm.js with a bounded scrollback buffer (5000 lines) and adding infinite scroll behavior to fetch older logs from Redis when the user scrolls to the top.Changes:
scrollback: 5000on xterm to cap DOM/memory usage regardless of stream lengthonScrollcallback to trigger paginated fetches from Redis (askRangewithFETCH_BATCH_SIZE = 200)disconnect(),off())Lineimport andresponsestate arrayuseCallbackto prevent unnecessary re-rendersReview & Testing Checklist for Human
./app/runner.sh | ./app/app) to verify the xterm scrollback limit caps at 5000 linesNotes
NODE_OPTIONS=--openssl-legacy-provideris required when building with Node 22 + react-scripts 4.x.Link to Devin session: https://app.devin.ai/sessions/62e7884e8d894e378e8df86605f9c1bd
Requested by: @braeden