FIX if a default choice is selected, make sure that's saved and displayed. Fixes3#4
Open
richardtape wants to merge 1 commit intobradvin:masterfrom
Open
FIX if a default choice is selected, make sure that's saved and displayed. Fixes3#4richardtape wants to merge 1 commit intobradvin:masterfrom
richardtape wants to merge 1 commit intobradvin:masterfrom
Conversation
Contributor
Author
|
This fix is broken in 1.9 as the $field parameter for determineIsSelected is now passed as a field object and not an array. Look for another branch to fix that, soon |
|
FYI, I have already submitted a pull request a little bit ago that fixes this for GF 1.9. However, it needs to check for pre-1.9 and allow for backwards-compatibility. Feel free to check out my pull request and update for backwards compatibility if you'd like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3