Remove BpffsInitImage configuration option#491
Open
frobware wants to merge 2 commits intobpfman:mainfrom
Open
Conversation
The BpffsInitImage field in DaemonSpec allowed overriding the init container image that mounts bpffs. This configurability is no longer required as the init container will use the agent image directly in subsequent changes. Remove the field from the API, the corresponding override logic from the controller, and update the tests to only cover CSI registrar image overrides. Signed-off-by: Andrew McDermott <amcdermo@redhat.com>
Regenerate the Config CRD and OLM bundle manifests following the removal of the BpffsInitImage field from the DaemonSpec API. Signed-off-by: Andrew McDermott <amcdermo@redhat.com>
frobware
force-pushed
the
remove-bpffs-init-image-config
branch
from
53a1085 to
f64349e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
bpffsInitImagefield from the Config API'sDaemonSpec. This field was added in #488 to allow overriding the init container image that mounts bpffs.This configurability is no longer required because #490 replaces the current init container with one that runs the bpfman-agent binary directly (with a
--mount-bpffsflag). The init container will therefore use the same image as the agent container, eliminating the need for a separate configurable image.Changes
BpffsInitImagefield fromDaemonSpecin the Config APIconfigureBpfmanDsRelated
bpffsInitImage--mount-bpffs