feat: add slack notification on failed integration tests#381
feat: add slack notification on failed integration tests#381hanshal101 wants to merge 2 commits intobpfman:mainfrom
Conversation
Signed-off-by: Hanshal Mehta <122217807+hanshal101@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage ? 28.13%
=======================================
Files ? 128
Lines ? 11209
Branches ? 0
=======================================
Hits ? 3154
Misses ? 7773
Partials ? 282
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Thanks for the contribution. I left some comments, but reading up on this some more it seems like webhooks are being deprecated no longer recommended for this usecase + we don't have the ability to add them easily on the K8s slack instance.
We can certainly request a webhook from the admins, but it might make more sense to do use the Github integration like this: https://github.com/integrations/slack?tab=readme-ov-file#workflow-notification-filters
That's more flexible since we can subscribe/unsubscribe to notifications in the channel whenever we like.
Signed-off-by: Hanshal Mehta <122217807+hanshal101@users.noreply.github.com>
|
Thanks @dave-tucker for the review, I have updated the CI to the official |
…s/component-update-ocp-bpfman chore(deps): update ocp-bpfman to 9a8ce55
Fixes #332
Closes #332
Description
This PR adds the feature to give alerts on slack when the integration tests fails.
TODO
@anfredette , we need to add a Github secret named
SLACK_WEBHOOK_URLto enable the alerts.