Remove ShowAbbreviationTitle option#161
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Co-authored-by: boxofyellow <54955040+boxofyellow@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
boxofyellow
May 22, 2026 11:29
View session
boxofyellow
requested changes
May 22, 2026
Owner
boxofyellow
left a comment
boxofyellow
left a comment
There was a problem hiding this comment.
@copilot please address this comment
| .WriteEscape(obj.Abbreviation.Text.ToString()) | ||
| .AddInLine("[/])"); | ||
| } | ||
| renderer |
Owner
There was a problem hiding this comment.
@copilot Please follow https://github.com/boxofyellow/ConsoleMarkdownRenderer/blob/main/docs/code-style.md#file-and-code-placement, how that the this is single line, lets remove this class file and place it ConsoleObjectRenderers.cs
Contributor
Author
There was a problem hiding this comment.
Moved into ConsoleObjectRenderers.cs and deleted the dedicated file in 474ea2c.
Co-authored-by: boxofyellow <54955040+boxofyellow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DisplayOptions.ShowAbbreviationTitlelet callers suppress the expansion that follows anAbbreviationInline, silently dropping part of the source Markdown. It shouldn't be configurable — the title is always rendered now.DisplayOptions: drop theShowAbbreviationTitleproperty, itsClone()assignment, and the cross-reference from theAbbreviationTitledoc comment.ConsoleAbbreviationInlineRenderer: remove the conditional; always emitlabel ([style]text[/])via the existing fluent chain.RendererTests_AbbreviationTitleSuppressed.RendererTests_AbbreviationTitleTestcontinues to cover the styled expansion.Upcoming Changes→Renderers.Breaking for any consumer that explicitly set
ShowAbbreviationTitle = false— those assignments must be removed.