Expose Spectre.Console Rule style for thematic breaks#144
Conversation
@copilot Are you sure? The title of the PR is still
Also the PRs description still contains many references to the the title property that was removed. |
You're right — I don't have the ability to edit the PR title (only the body), so the title still mentions "title". Could you rename it to something like "Expose Spectre.Console Rule style for thematic breaks"? My previous |
@copilot Here is the current body of the PR description
Why don't you respond with an updated version. |
Here's an updated description that drops the title references:
Changes
Usagevar options = new DisplayOptions
{
ThematicBreak = new TextStyle(foreground: TextColor.Yellow),
};Renders each Also, suggested updated title: Expose Spectre.Console Rule style for thematic breaks (I can't edit the title myself). |
boxofyellow
left a comment
There was a problem hiding this comment.
@copilot This PR need to be rebased (not just having master merged on top). However you will not have permission to forcepush changes.
Please checkout the main branch, create a new branch and then replay this PRs commits onto top of that new branch while addressing conflicts.
When you are done please let me know the name of the new branch you created.
Co-authored-by: boxofyellow <54955040+boxofyellow@users.noreply.github.com>
Co-authored-by: boxofyellow <54955040+boxofyellow@users.noreply.github.com>
Co-authored-by: boxofyellow <54955040+boxofyellow@users.noreply.github.com>
Co-authored-by: boxofyellow <54955040+boxofyellow@users.noreply.github.com>
Co-authored-by: boxofyellow <54955040+boxofyellow@users.noreply.github.com>
Done. The new branch is
|
8f5dbb8 to
143bd2d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=======================================
Coverage 95.80% 95.81%
=======================================
Files 30 30
Lines 1694 1696 +2
Branches 179 179
=======================================
+ Hits 1623 1625 +2
Misses 46 46
Partials 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ConsoleRendererBase.AddThematicBreakImplementationrenderednew Rule()with no way for callers to influence the line color, leaving thematic breaks visually indistinguishable in busy terminal output.Changes
DisplayOptions: NewThematicBreak(TextStyle, defaultnew()) property, included inClone().ConsoleRendererBase:AddThematicBreakImplementationnow appliesOptions.ThematicBreak.ToSpectreStyle()toRule.Style.ThematicBreaktom_crazyOptionsandRendererTests_ThematicBreak*cases covering default + custom style propagation onto the rule segment.## Upcoming Changes→### :art: Renderers :art:.Usage
Renders each
---in the document as a yellow rule line. Defaults preserve the existing unadorned-rule behavior.