test(sdk-typescript): pass jest target when no test files exist#617
Open
G4614 wants to merge 1 commit into
Open
test(sdk-typescript): pass jest target when no test files exist#617G4614 wants to merge 1 commit into
G4614 wants to merge 1 commit into
Conversation
@nx/jest/plugin (apps/nx.json) infers a `test` target from this project's jest.config.js. The package has no test files yet, and jest exits non-zero on "No tests found" by default, so `nx run sdk-typescript:test` (and `make test:apps` which fans out to it) fails with exit code 1. Set `passWithNoTests: true` in the jest config so the empty case is a success. Real test failures, once tests are added, still fail. Verified: `yarn nx run sdk-typescript:test` → "exiting with code 0". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#460 added test config but didn't add real tests, now pass with no test should be set
Test plan
yarn nx test sdk-typescript --skip-nx-cache(no VM):passWithNoTestsNo tests found, exiting with code 1(nx task fails, rc=1)passWithNoTests: trueNo tests found, exiting with code 0(rc=0)