fix(test:apps): inject boxlite_dev tag via GOFLAGS for apps Go tests (#579)#589
Open
G4614 wants to merge 1 commit into
Open
fix(test:apps): inject boxlite_dev tag via GOFLAGS for apps Go tests (#579)#589G4614 wants to merge 1 commit into
G4614 wants to merge 1 commit into
Conversation
7a5a78c to
5e4ccff
Compare
5e4ccff to
256cc9f
Compare
5c512ba to
c240495
Compare
f763f72 to
0ddf77b
Compare
…oxlite-ai#579) apps/ Go test targets must build with `-tags=boxlite_dev` so cgo selects sdks/go/bridge_cgo_dev.go, which links the in-repo sdks/c/include headers and the dev-built target/debug/libboxlite.a. Without the tag, go uses bridge_cgo_prebuilt.go, which needs the downloaded sdks/go/{libboxlite.a, include} bundle (absent on dev checkouts) and fails to link — issue boxlite-ai#579. A prior attempt set `options.flags` in apps/nx.json, but released @nx-go/nx-go ignores it (its go-test argv is hardcoded). Since @nx-go/nx-go passes process.env through to the spawned `go test`, set GOFLAGS=-tags=boxlite_dev on the `make test:apps` recipe — the same pattern test:unit:go already uses for the SDK's own tests. test:apps also gains a dev:go prerequisite so target/debug/libboxlite.a is built first. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
0ddf77b to
f7e61ed
Compare
Contributor
Author
|
Caveat — the tag is injected only via Line 309 sets
Neither case affects CI. If standalone Test plan
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set
GOFLAGS=-tags=boxlite_devon themake test:appsrecipe so the apps' Go tests link the dev-builttarget/debug/libboxlite.a(viasdks/go/bridge_cgo_dev.go) instead of the prebuilt bundle absent on dev checkouts — fixes #579.