Apply all of patch changes #4407
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update React peer dependencies to support v19 - Migrate from ReactDOM.render to createRoot API - Update tabbable imports for v6 compatibility - Fix unmount logic in ES6Wrapper
This ensures the es directory is built when installing from GitHub
- Add canMove and onItemMove props to ItemOptions component - Add 'Move' menu item to dropdown with messages support - Update column headers from ALL CAPS to proper case (Name, Modified, Size, Actions, Details) - Add move method placeholder to ContentExplorer - Update TypeScript interfaces for new props - Fix tests to include new required props These changes restore the custom functionality previously applied via patch-package.
- Add explicit type annotations for debounce/throttle functions - Fix Media component typing to support static properties - Skip TypeScript definition generation to avoid CI path issues - Resolves GitHub Actions build failures while maintaining functionality
…uild - Added babel-plugin-transform-define to babel.config.js - Configured it to replace __VERSION__ with package.json version - This fixes ReferenceError: __VERSION__ is not defined when using ES modules - Required for consuming apps that import ES modules instead of webpack dist builds
This commit applies custom patches to support move operations and component customization in the content explorer and picker components. Changes: - Add move functionality for files/folders with proper UI feedback - Added canMove prop and onItemMove callback to ItemOptions - Added move message for internationalization - Prevent moving items into themselves - Filter out items being moved from item lists - Enable component customization - Add component override system (Header, SubHeader, Content, CreateFolderDialog) - Support custom headers/subheaders in ContentPicker - Add headerActionButtons prop for additional header actions - Improve UX for move operations - Change button text from "Choose" to "Move" in VIEW_SELECTED mode - Toggle between VIEW_SELECTED and VIEW_FOLDER states - Pass itemBeingMovedId through component tree for consistent state - Update ContentExplorer with new props: - components, headerActionButtons, itemBeingMovedId, move, moveCallback - Swap Header and SubHeader positions for better layout These changes enable the box-ui-elements fork to support advanced file/folder management operations while maintaining backward compatibility. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
|
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughPR introduces React 19 compatibility with updated dependencies, migrates deprecated React render APIs to createRoot, implements item move functionality across content explorer/picker components, upgrades tabbable imports to named style, and adds enhanced type annotations and Babel versioning support. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (28)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies custom patches from the box-ui-elements@23.3.0.patch to support move operations and component customization in the content explorer and picker components.
Changes
🚀 Move Functionality
canMoveprop andonItemMovecallback to ItemOptionscomponent
🎨 Component Customization
Content, and CreateFolderDialog components
prop forwarding
headerActionButtonsprop for additional header actions💡 UX Improvements
VIEW_SELECTED mode
itemBeingMovedIdthrough thecomponent tree
📝 Updated ContentExplorer Props
components,headerActionButtons,itemBeingMovedId,move,moveCallbackTechnical Details
backward compatibility
Testing
Impact
These changes enable the box-ui-elements fork to support advanced
file/folder management operations while maintaining full backward
compatibility. This is essential for our React 19 migration and custom
file management workflows.
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.