-
Notifications
You must be signed in to change notification settings - Fork 344
Fix version variable #4405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version variable #4405
Conversation
- Update React peer dependencies to support v19 - Migrate from ReactDOM.render to createRoot API - Update tabbable imports for v6 compatibility - Fix unmount logic in ES6Wrapper
This ensures the es directory is built when installing from GitHub
- Add canMove and onItemMove props to ItemOptions component - Add 'Move' menu item to dropdown with messages support - Update column headers from ALL CAPS to proper case (Name, Modified, Size, Actions, Details) - Add move method placeholder to ContentExplorer - Update TypeScript interfaces for new props - Fix tests to include new required props These changes restore the custom functionality previously applied via patch-package.
- Add explicit type annotations for debounce/throttle functions - Fix Media component typing to support static properties - Skip TypeScript definition generation to avoid CI path issues - Resolves GitHub Actions build failures while maintaining functionality
…uild - Added babel-plugin-transform-define to babel.config.js - Configured it to replace __VERSION__ with package.json version - This fixes ReferenceError: __VERSION__ is not defined when using ES modules - Required for consuming apps that import ES modules instead of webpack dist builds
|
|
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request updates the codebase to support React 19, adds build-time version injection via Babel, refactors the tabbable library import to use named exports, migrates React DOM rendering in wrapper components from deprecated render to createRoot API, adds a "move" action capability to items with related type definitions, and includes request interception timestamp tracking in the mock service worker. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (24)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.