Calculate/save parallel distance along flux surfaces#193
Merged
Conversation
Expected results of tests updated to add the new `parallel_distance` variables. Allow tolerances to be increased for certain variables in the integrated tests when adding random noise, to deal with certain variables seeming to be more sensitive. For now, applies only to "ShiftTorsion_ylow".
johnomotani
force-pushed
the
calculate-parallel-distance
branch
from
a3c8e82 to
7fc3e43
Compare
Collaborator
|
Thanks for this, it would be very helpful to have this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parallel connection length is not needed by BOUT++, but can be nice to know. By calculating during the grid generation process we can do the integration using FineContour objects for increased accuracy, rather than depending on the poloidal resolution of the grid.
Slightly unfortunately requires passing
equilibriumobjects down into fairly low-level methods in order to be able to calculateBandBp. Due to this, modifies a relatively large number of methods, because like thepsiinterpolating function, theequilibriumhas to be constructed independently on each of the parallel worker processes, and passed in explicitly as a keyword argument inparallel_map.Expected results of tests updated to add the new
parallel_distancevariables, as well as a couple of others that had been previously added since the expected outputs were last updated.Allow tolerances to be increased for certain variables in the integrated tests when adding random noise, to deal with certain variables seeming to be more sensitive. For now, applies only to "ShiftTorsion_ylow".
doc/whats-new.mdwith a summary of the changes