Shorten timestep on 2D-production/recycling tests#533
Merged
Conversation
I checked that the tests are still sensitive. On my system they take ~35s each with the vast majority of the time taken by xBOUT loading.
mikekryjak
force-pushed
the
faster-tests
branch
from
8ee0c04 to
68bb8e9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
=======================================
Coverage 45.42% 45.42%
=======================================
Files 93 93
Lines 9608 9608
Branches 1394 1394
=======================================
Hits 4364 4364
Misses 4784 4784
Partials 460 460 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrhardman
added a commit
to UKAEA-Edge-Code/hermes-3
that referenced
this pull request
Mar 27, 2026
…g/docker-image-shorten-tests Shorten tests, following boutproject#533. Use target=x86_64_v3 in spack built to try to avoid inconsistency between runner used to build the image and the runner used for the tests.
Collaborator
Author
|
@bendudson ready for review |
HCX refactor PR (#398) introduced tiny changes which were merged into master between me shortening the tests and merging the PR
oparry-ukaea
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced the required timestep/nout for 2D-recycling and 2D-production to a very small amount.
On my system they take ~35s each with the vast majority of the time taken by xBOUT loading.
I also added some more verbosity and timing messages. Verbosity is now True by default. It's only a handful of lines and the extra timing information could come in handy.
We could get further speedups with the new, faster xBOUT loading (boutproject/xBOUT#336) but this is still not yet merged due to yet another issue with xBOUT tests - this time it looks like it's an Xarray file lock race condition which shows up only in newer Python versions.
Technically the tests could be rewritten to use
boutdata.collect, but this would not be trivial since they use xHermes region selection logic.