Pytest integrated#3331
Open
tomc271 wants to merge 193 commits into
Open
Conversation
ZedThree
reviewed
Mar 18, 2026
matching either to a file named `test_foo.py`.
Native configuration is x86_64-pc-linux-gnu
=== tests ===
Schedule of variations:
unix
Running target unix
Using /usr/share/dejagnu/baseboards/unix.exp as board description file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file for target.
=== Summary === to in CMakeLists.txt
so that the `input` directory is found.
so that the `test` directory is found.
so that the `data` directory is found.
Fails due to missing file `grid.fci.nc`.
Change directory to exe location prior to attempting to run it.
Change directory to exe location prior to attempting to run it.
Change directory to exe location prior to attempting to run it.
tomc271
force-pushed
the
pytest-integrated
branch
from
87931a7 to
f872de6
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| if (!_cell_area_xlow.has_value()) { | ||
| _compute_cell_area_x(); | ||
| } | ||
| return *_cell_area_xlow; |
Contributor
There was a problem hiding this comment.
warning: unchecked access to optional value [bugprone-unchecked-optional-access]
return *_cell_area_xlow;
^|
|
||
| void Coordinates::_compute_cell_area_y() const { | ||
| _compute_Jxz_cell_faces(); | ||
| if (_jxz_centre->isFci()) { |
Contributor
There was a problem hiding this comment.
warning: unchecked access to optional value [bugprone-unchecked-optional-access]
if (_jxz_centre->isFci()) {
^| ASSERT2(isUniform(dx, false, "RGN_ALL")); | ||
| ASSERT3(isUniform(dz, true, "RGN_ALL")); | ||
| ASSERT2(isUniform(dz, false, "RGN_ALL")); | ||
| _cell_area_ylow.emplace(*_jxz_ylow * dx * dz); |
Contributor
There was a problem hiding this comment.
warning: unchecked access to optional value [bugprone-unchecked-optional-access]
_cell_area_ylow.emplace(*_jxz_ylow * dx * dz);
^| ASSERT3(isUniform(dz, true, "RGN_ALL")); | ||
| ASSERT2(isUniform(dz, false, "RGN_ALL")); | ||
| _cell_area_ylow.emplace(*_jxz_ylow * dx * dz); | ||
| _cell_area_yhigh.emplace(*_jxz_yhigh * dx * dz); |
Contributor
There was a problem hiding this comment.
warning: unchecked access to optional value [bugprone-unchecked-optional-access]
_cell_area_yhigh.emplace(*_jxz_yhigh * dx * dz);
^(remove spurious collect() wrapper).
Relying on `boutpp.finalise()` doesn't work as xdist workers are reused between tests, so this fixture calls the test via subprocess to ensure isolation.
Isolate boutpp initialization via subprocess fixture * Enable set -e in the test script to ensure CI correctly reports failures. * Implement a run_isolated fixture to spawn a fresh process for tests using the boutpp C++ singleton. * Resolve pytest-xdist worker crashes caused by persistent MPI and library state.
Passing sys.argv[1:] to boutpp.init() caused problems when run in an isolated python process.
Return a function that evaluates to True in the parent (to abort test execution) and False in the child (to run the actual test).
Fedora CI workflow fails unless openmpi environment variables are cleared between each test.
Increase size of /dev/shm partition to 1GB.
This is used in `run_integrated_tests.sh` to determine the verbosity level for pytest.
to prevent type-checker warnings.
tomc271
force-pushed
the
pytest-integrated
branch
from
303d76c to
b6b4e1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.