Skip to content

Improve saveParallel #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZedThree merged 3 commits into from
Mar 11, 2026
Merged

Improve saveParallel #3306

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92d03c1
Do not rely on valid region being set
dschwoerer Feb 10, 2026
201a969
Ignore if field is not allocated
dschwoerer Feb 10, 2026
a164799
Use fmt syntax, not python f-string
dschwoerer Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/sys/options.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,10 +364,18 @@ void saveParallel(Options& opt, const std::string& name, const Field3D& tosave)
Field3D tmp;
tmp.allocate();
const auto& fpar = tosave.ynext(i);
for (auto j : fpar.getValidRegionWithDefault("RGN_NO_BOUNDARY")) {
tmp[j.yp(-i)] = fpar[j];
if (fpar.isAllocated()) {
for (auto j : tmp.getRegion("RGN_NOY")) {
tmp[j] = fpar[j.yp(i)];
}
opt[fmt::format("{}_y{:+d}", name, i)] = tmp;
} else {
if (tosave.isFci()) { // likely an error
throw BoutException(
"Tried to save parallel fields - but parallel field {} is not allocated",
i);
}
}
opt[fmt::format("{}_y{:+d}", name, i)] = tmp;
}
}
}
Expand Down
Loading