Fix shiftedmetricinterp unit test#3277
Closed
ZedThree wants to merge 3 commits into
Closed
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
Ah, we have found the test fails when the region manipulation in This is coming from communicating the solution inside the Laplace solver. The solver is only applying its BCs one boundary cell deep, and we get a NaN from the second one (the outer most boundary cell). We (probably) can't just apply our own BCs here in case they conflict with the solver's, but it's possible we could just extrapolate or something to the outer boundary cells. I think the simplest thing is to just revert those changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd forgotten to commit setting
GlobalNzNoBoundariesinFakeMesh🤦As discussed in the other PR, I've also set the region for Z interpolation to be
NOY