Forward arguments to BoutException and Output::write#3224
Merged
Conversation
This enables passing views like `fmt::join` which otherwise fail with: ``` error: static assertion failed: passing views as lvalues is disallowed ```
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| Dl_info info; | ||
| void* ptr = trace[i]; | ||
| if (dladdr(trace[i], &info)) { | ||
| const void* ptr = trace[i]; |
Contributor
There was a problem hiding this comment.
warning: do not use array subscript when the index is not an integer constant expression [cppcoreguidelines-pro-bounds-constant-array-index]
const void* ptr = trace[i];
^| // Additionally, check whether this is the default offset for an executable | ||
| if (info.dli_fbase != reinterpret_cast<void*>(0x400000)) { | ||
| ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(trace[i]) | ||
| ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(ptr) |
Contributor
There was a problem hiding this comment.
warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(ptr)
^| // Additionally, check whether this is the default offset for an executable | ||
| if (info.dli_fbase != reinterpret_cast<void*>(0x400000)) { | ||
| ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(trace[i]) | ||
| ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(ptr) |
Contributor
There was a problem hiding this comment.
warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(ptr)
^| // Additionally, check whether this is the default offset for an executable | ||
| if (info.dli_fbase != reinterpret_cast<void*>(0x400000)) { | ||
| ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(trace[i]) | ||
| ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(ptr) |
Contributor
There was a problem hiding this comment.
warning: integer to pointer cast pessimizes optimization opportunities [performance-no-int-to-ptr]
ptr = reinterpret_cast<void*>(reinterpret_cast<size_t>(ptr)
^
dschwoerer
approved these changes
Dec 5, 2025
Contributor
dschwoerer
left a comment
dschwoerer
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables passing views like
fmt::joinwhich otherwise fail with:Very simple fix: change the argument types to
Args&&...(universal forwardingreference) and call
std::forward.Plus some drive-by clang-tidy fixes.