Remove deprecated FieldGenerator::generate#3216
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ZedThree
force-pushed
the
remove-deprecated-generator-method
branch
from
93e301b to
ab58ba5
Compare
dschwoerer
approved these changes
Dec 1, 2025
Contributor
dschwoerer
left a comment
dschwoerer
left a comment
There was a problem hiding this comment.
Thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only use was in boundary conditions at
CELL_ZLOW. It look a minute for meto understand what was happening here and why we couldn't just use
Context()already -- we need to set a custom
xORydepending on where the boundaryis, although at first glance it looks like we're setting both, the trick is that
only one of
bndry->bx/byis actually non-zero.An alternative to this would be to change
Context(BoundaryRegion)to use thestaggered location like a bitfield and pass e.g.
CELL_XLOW | CELL_ZLOW. Thiswould avoid some duplicated work.
The only remaining use of a deprecated function is now
Mesh::firstY()/lastY(),again in the boundaries, although
BoutMeshalso uses it without passingxpos.I suppose this also serves as our annual reminder that the boundaries need a
complete refactor.