Merge v5.2.0 into next#3179
Merged
Merged
Conversation
Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v2.0.0...v2.1.1) --- updated-dependencies: - dependency-name: numpy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [externalpackages/googletest](https://github.com/google/googletest) from `0953a17` to `6dae7eb`. - [Release notes](https://github.com/google/googletest/releases) - [Commits](google/googletest@0953a17...6dae7eb) --- updated-dependencies: - dependency-name: externalpackages/googletest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…nalpackages/googletest-6dae7eb Bump externalpackages/googletest from `0953a17` to `6dae7eb`
…-eq-2.1.1 Update numpy requirement from ~=2.0.0 to ~=2.1.1
Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v2.1.1...v2.1.2) --- updated-dependencies: - dependency-name: numpy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…-eq-2.1.2 Update numpy requirement from ~=2.1.1 to ~=2.1.2
master branch will be 5.1.2 not 5.2.0
Bumps [externalpackages/googletest](https://github.com/google/googletest) from `6dae7eb` to `d144031`. - [Release notes](https://github.com/google/googletest/releases) - [Commits](google/googletest@6dae7eb...d144031) --- updated-dependencies: - dependency-name: externalpackages/googletest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…nalpackages/googletest-d144031 Bump externalpackages/googletest from `6dae7eb` to `d144031`
Bumps [ZedThree/clang-tidy-review](https://github.com/zedthree/clang-tidy-review) from 0.19.0 to 0.20.1. - [Release notes](https://github.com/zedthree/clang-tidy-review/releases) - [Changelog](https://github.com/ZedThree/clang-tidy-review/blob/master/CHANGELOG.md) - [Commits](ZedThree/clang-tidy-review@v0.19.0...v0.20.1) --- updated-dependencies: - dependency-name: ZedThree/clang-tidy-review dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4 to 5. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v4...v5) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…odecov/codecov-action-5 Bump codecov/codecov-action from 4 to 5
…edThree/clang-tidy-review-0.20.1 Bump ZedThree/clang-tidy-review from 0.19.0 to 0.20.1
Use PEP 625 compatible archive name
Updates the requirements on [numpy](https://github.com/numpy/numpy) to permit the latest version. - [Release notes](https://github.com/numpy/numpy/releases) - [Changelog](https://github.com/numpy/numpy/blob/main/doc/RELEASE_WALKTHROUGH.rst) - [Commits](numpy/numpy@v2.1.2...v2.2.1) --- updated-dependencies: - dependency-name: numpy dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [externalpackages/googletest](https://github.com/google/googletest) from `d144031` to `504ea69`. - [Release notes](https://github.com/google/googletest/releases) - [Commits](google/googletest@d144031...504ea69) --- updated-dependencies: - dependency-name: externalpackages/googletest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…nalpackages/googletest-504ea69 Bump externalpackages/googletest from `d144031` to `504ea69`
…-eq-2.2.1 Update numpy requirement from ~=2.1.2 to ~=2.2.1
Bumps [externalpackages/googletest](https://github.com/google/googletest) from `504ea69` to `2b6b042`. - [Release notes](https://github.com/google/googletest/releases) - [Commits](google/googletest@504ea69...2b6b042) --- updated-dependencies: - dependency-name: externalpackages/googletest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…nalpackages/googletest-2b6b042 Bump externalpackages/googletest from `504ea69` to `2b6b042`
Bumps [externalpackages/boutdata](https://github.com/boutproject/boutdata) from `e458cf0` to `0aaef41`. - [Release notes](https://github.com/boutproject/boutdata/releases) - [Commits](boutproject/boutdata@e458cf0...0aaef41) --- updated-dependencies: - dependency-name: externalpackages/boutdata dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Updates the requirements on [pygithub](https://github.com/pygithub/pygithub) to permit the latest version. - [Release notes](https://github.com/pygithub/pygithub/releases) - [Changelog](https://github.com/PyGithub/PyGithub/blob/main/doc/changes.rst) - [Commits](PyGithub/PyGithub@v2.4.0...v2.6.0) --- updated-dependencies: - dependency-name: pygithub dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…rox-eq-2.8 Update pygithub requirement from ~=2.7 to ~=2.8
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 5 to 6. - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v5...v6) --- updated-dependencies: - dependency-name: actions/setup-python dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
* master: (57 commits) Update pygithub requirement from ~=2.7 to ~=2.8 Bump actions/checkout from 4 to 5 Bump externalpackages/googletest from `bac6a8f` to `244cec8` Update pygithub requirement from ~=2.6 to ~=2.7 Bump externalpackages/boutdata from `a7a372d` to `7164a89` Remove coverage test from github workflow Try to do the right thing for linking netCDF::netcdf coloring for petsc solver is very likely broken CI: Switch to released fedora CI: require python3-boututils CI: Bump all ubuntu images Convert macro to constexpr template function Move "maybe cast" macro to header for reuse Fix PETSc version check for MatFDColoringFn typedef Update docs for what PETSc we support Add PETSc version guards for function cast Replace deprecated `boututils.file_import` Bump externalpackages/boutdata from `0aaef41` to `a7a372d` Bump externalpackages/googletest from `2b6b042` to `bac6a8f` Add back in C language for SUNDIALS ...
…ctions/setup-python-6 Bump actions/setup-python from 5 to 6
Better pypi package (master)
Release V5.2.0
* master: (78 commits)
Bump DOI
Add shim for ARKodeGetNumRhsEvals
Suppress warning from `nodiscard` function
Remove `boututils` from requirements; bump `boutdata`
Fix deprecation warning
Bump bundled fmt
Fix some easy clang-tidy snes warnings
Fix reorder warning from snes
CI: Don't run clang-{tidy,format} on RC branches
Update changelog
Bump version to 5.2.0
Tweak version updater, mention in docs
Add dependencies to changelog updater
Add new authors
Tweak citations updater, mention in docs
Update translations
Bump actions/setup-python from 5 to 6
Fix spacing
Add content type
Fix spacing
...
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return ARKStepGetNumRhsEvals(arkode_mem, num_rhs_evals, &temp); | ||
| } else { | ||
| return ARKStepGetNumRhsEvals(arkode_mem, &temp, num_rhs_evals); | ||
| } |
Contributor
There was a problem hiding this comment.
warning: do not use 'else' after 'return' [readability-else-after-return]
Suggested change
| } | |
| } return ARKStepGetNumRhsEvals(arkode_mem, &temp, num_rhs_evals); | |
| * to an SNESSolver object. | ||
| */ | ||
| static PetscErrorCode FormFunction(SNES UNUSED(snes), Vec x, Vec f, void* ctx) { | ||
| PetscErrorCode FormFunction(SNES UNUSED(snes), Vec x, Vec f, void* ctx) { |
Contributor
There was a problem hiding this comment.
warning: no header providing "PetscErrorCode" is directly included [misc-include-cleaner]
src/solver/impls/snes/snes.cxx:1:
+ #include <petscsystypes.h>| * to an SNESSolver object. | ||
| */ | ||
| static PetscErrorCode FormFunction(SNES UNUSED(snes), Vec x, Vec f, void* ctx) { | ||
| PetscErrorCode FormFunction(SNES UNUSED(snes), Vec x, Vec f, void* ctx) { |
Contributor
There was a problem hiding this comment.
warning: no header providing "UNUSED" is directly included [misc-include-cleaner]
src/solver/impls/snes/snes.cxx:1:
+ #include "bout/unused.hxx"| * to an SNESSolver object. | ||
| */ | ||
| static PetscErrorCode FormFunction(SNES UNUSED(snes), Vec x, Vec f, void* ctx) { | ||
| PetscErrorCode FormFunction(SNES UNUSED(snes), Vec x, Vec f, void* ctx) { |
Contributor
There was a problem hiding this comment.
warning: no header providing "Vec" is directly included [misc-include-cleaner]
src/solver/impls/snes/snes.cxx:1:
+ #include <petscvec.h>| static PetscErrorCode snesPCapply(PC pc, Vec x, Vec y) { | ||
| int ierr; | ||
|
|
||
| PetscErrorCode snesPCapply(PC pc, Vec x, Vec y) { |
Contributor
There was a problem hiding this comment.
warning: no header providing "PC" is directly included [misc-include-cleaner]
src/solver/impls/snes/snes.cxx:1:
+ #include <petscpctypes.h>| // Get the context | ||
| SNESSolver* s; | ||
| ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); | ||
| int ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); |
Contributor
There was a problem hiding this comment.
warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
int ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s));
^| // Get the context | ||
| SNESSolver* s; | ||
| ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); | ||
| int ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); |
Contributor
There was a problem hiding this comment.
warning: multilevel pointer conversion from 'void **' to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]
int ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s));
^| // Get the context | ||
| SNESSolver* s; | ||
| ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); | ||
| int ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); |
Contributor
There was a problem hiding this comment.
warning: no header providing "PCShellGetContext" is directly included [misc-include-cleaner]
src/solver/impls/snes/snes.cxx:1:
+ #include <petscpc.h>| // Get the context | ||
| SNESSolver* s; | ||
| ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); | ||
| int ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); |
Contributor
There was a problem hiding this comment.
warning: variable 'ierr' of type 'int' can be declared 'const' [misc-const-correctness]
Suggested change
| int ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); | |
| int const ierr = PCShellGetContext(pc, reinterpret_cast<void**>(&s)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.