fix(tests): fetch kits for host architecture#638
Open
cbgbt wants to merge 1 commit intobottlerocket-os:developfrom
Open
fix(tests): fetch kits for host architecture#638cbgbt wants to merge 1 commit intobottlerocket-os:developfrom
cbgbt wants to merge 1 commit intobottlerocket-os:developfrom
Conversation
The variant_build tests hardcoded x86_64 for fetch but twoliter make defaults to host architecture. On aarch64 hosts, this caused builds to fail looking for kits that were never fetched.
jmt-lab
approved these changes
Feb 12, 2026
piyush-jena
approved these changes
Feb 25, 2026
Contributor
|
Is this one of the things needed for #253? |
yeazelm
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
make buildwas failing on my aarch64 host. It turns out this is because we would fetch for x86_64 but then call twoliter without providing an arch later, which would cause it to default to the host architecture.Testing done:
make buildnow passes on my aarch64 dev hostTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.