disable in-place updates for dev variants#4765
Open
bcressey wants to merge 2 commits intobottlerocket-os:developfrom
Open
disable in-place updates for dev variants#4765bcressey wants to merge 2 commits intobottlerocket-os:developfrom
bcressey wants to merge 2 commits intobottlerocket-os:developfrom
Conversation
Moving defaults to a separate file allows updates to be disabled for certain variants, to facilitate testing. Signed-off-by: Ben Cressey <bcressey@amazon.com>
The "dev" variants are not published (or supported), so in-place updates won't be available. Disabling this functionality makes it easier to test some scenarios. For example, `pcrsys` will generate additional PCR predictions for a variant at build time if in-place updates are disabled. Signed-off-by: Ben Cressey <bcressey@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Split updates-related defaults into a separate file included by all variants.
Adjust feature flags, defaults, and plugin for
*-devto disable in-place updates and remove all implicit references to that functionality.This simplifies testing for variants that don't support in-place updates.
Testing done:
Built
aws-dev. Verified that it booted correctly and that no updates-related settings were available.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.