macros: add configurable SBOM build directory#328
Open
rpkelly wants to merge 2 commits intobottlerocket-os:developfrom
Open
macros: add configurable SBOM build directory#328rpkelly wants to merge 2 commits intobottlerocket-os:developfrom
rpkelly wants to merge 2 commits intobottlerocket-os:developfrom
Conversation
Signed-off-by: Richard Kelly <rpkelly@amazon.com>
…tion Signed-off-by: Richard Kelly <rpkelly@amazon.com>
rpkelly
force-pushed
the
sbom-build-dir
branch
from
1474a7a to
d8f7d0d
Compare
Contributor
Can you say more about this? I don't really follow the downstream implications. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Rust packages i n the core and kernel kit redefine the generate sbom macro purely so that that they can change the build_dir used by the macro. By exposing the directory as a different, redefinable macro we simplify what these sorts of packages need to change.
Removing the
buildsubdirbroadens the scope of packages that will generate an SBOM package. While many of these will be blank SBOMs, some will not so, we'll opt for the widest possible net.Testing done:
Built an SDK and then a core kit
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.