pluto: use apiclient API rather than CLI#652
Open
fletcherw wants to merge 1 commit intobottlerocket-os:developfrom
Open
pluto: use apiclient API rather than CLI#652fletcherw wants to merge 1 commit intobottlerocket-os:developfrom
fletcherw wants to merge 1 commit intobottlerocket-os:developfrom
Conversation
fletcherw
force-pushed
the
pluto_tweaks
branch
2 times, most recently
from
309a1b5 to
3dba719
Compare
Replace the calls to shell out to `apiclient` with direct API calls. Add logging so that we can better monitor time spent on each portion of pluto.
fletcherw
force-pushed
the
pluto_tweaks
branch
from
3dba719 to
8ad3ea6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Replace the calls to shell out to
apiclientwith direct API calls.Add logging (similar to what sundog does) so that we can better monitor time spent on each portion of pluto via journald
Testing done:
Unit tests
built and launched EKS Auto AMI
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.