[BUG-fix] Cannot Start-VMX with error Vmware version not match #23#26
Open
azhahes wants to merge 2 commits intobottkars:masterfrom
Open
[BUG-fix] Cannot Start-VMX with error Vmware version not match #23#26azhahes wants to merge 2 commits intobottkars:masterfrom
azhahes wants to merge 2 commits intobottkars:masterfrom
Conversation
atwork317
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the logic for matching the VMware version and VM hardware version is changed as per this link. Created a new function to get the VM hardware version by passing VM ware major version as a parameter.
PS: From a maintainability perspective this is not the correct fix, since in the future the version keeps on increasing.