Conversation
WalkthroughThe GitHub Actions workflow .github/workflows/addon-checker.yml updates action versions (checkout to v4; Kodi addon checker to v1.3) and inserts a blank line after the addon-id step. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
.github/workflows/addon-checker.yml (2)
14-18: Addon checker v1.3 looks fine; make is‑pr dynamic and confirm kodi-version usage.
- Set is-pr based on the event so PRs are handled correctly.
- Please confirm that kodi-version: matrix is intentional and supported by this action; if not, specify concrete versions or add a job matrix.
Proposed tweak:
with: - kodi-version: matrix - is-pr: false + kodi-version: matrix + is-pr: ${{ github.event_name == 'pull_request' }}
19-19: Fix trailing whitespace and add a newline at EOF (yamllint error).Remove the stray spaces and ensure the file ends with a newline to satisfy yamllint.
Apply:
- addon-id: ${{ github.event.repository.name }} - + addon-id: ${{ github.event.repository.name }} +
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/addon-checker.yml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/addon-checker.yml
[error] 19-19: no new line character at the end of file
(new-line-at-end-of-file)
Summary by CodeRabbit