Skip to content

Update addon-checker.yml#3

Merged
bossanova808 merged 1 commit intomainfrom
update-addon-checker
Sep 20, 2025
Merged

Update addon-checker.yml#3
bossanova808 merged 1 commit intomainfrom
update-addon-checker

Conversation

@bossanova808
Copy link
Owner

@bossanova808 bossanova808 commented Sep 20, 2025

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow to newer action versions for improved reliability and compatibility during add-on checks.
  • Style
    • Minor formatting tidy-up in the workflow configuration.

@coderabbitai
Copy link

coderabbitai bot commented Sep 20, 2025

Walkthrough

The GitHub Actions workflow .github/workflows/addon-checker.yml updates action versions (checkout to v4; Kodi addon checker to v1.3) and inserts a blank line after the addon-id step.

Changes

Cohort / File(s) Summary of changes
CI workflow version bumps
.github/workflows/addon-checker.yml
Upgraded actions/checkout from v1 to v4; upgraded xbmc/action-kodi-addon-checker from v1.1 to v1.3.
Whitespace/formatting
.github/workflows/addon-checker.yml
Inserted a blank line after the addon-id step.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

Pipelines hum with fresher tune,
Versions rise like silver moon.
A gentle space, a tidy line,
CI steps now more aligned.
Small tweaks set the checks to glide—
Green lights wink, and tests abide.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Update addon-checker.yml" is concise and accurately describes the primary change in the changeset—updating the GitHub Actions workflow file (.github/workflows/addon-checker.yml) to newer action versions. It is specific, clear, and suitable for a teammate scanning the project history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-addon-checker

Comment @coderabbitai help to get the list of available commands and usage tips.

@bossanova808 bossanova808 merged commit 783389f into main Sep 20, 2025
0 of 3 checks passed
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (2)
.github/workflows/addon-checker.yml (2)

14-18: Addon checker v1.3 looks fine; make is‑pr dynamic and confirm kodi-version usage.

  • Set is-pr based on the event so PRs are handled correctly.
  • Please confirm that kodi-version: matrix is intentional and supported by this action; if not, specify concrete versions or add a job matrix.

Proposed tweak:

       with:
-        kodi-version: matrix
-        is-pr: false
+        kodi-version: matrix
+        is-pr: ${{ github.event_name == 'pull_request' }}

19-19: Fix trailing whitespace and add a newline at EOF (yamllint error).

Remove the stray spaces and ensure the file ends with a newline to satisfy yamllint.

Apply:

-        addon-id: ${{ github.event.repository.name }}
-        
+        addon-id: ${{ github.event.repository.name }}
+
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfa3d1e and b0443c0.

📒 Files selected for processing (1)
  • .github/workflows/addon-checker.yml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
.github/workflows/addon-checker.yml

[error] 19-19: no new line character at the end of file

(new-line-at-end-of-file)

@bossanova808 bossanova808 deleted the update-addon-checker branch September 20, 2025 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant