Open
Conversation
szepeviktor
reviewed
Dec 24, 2023
|
|
||
| # 2nd, 3rd | ||
| nd | ||
| and |
szepeviktor
reviewed
Dec 24, 2023
|
|
||
| # 2nd, 3rd | ||
| nd | ||
| and |
szepeviktor
reviewed
Dec 24, 2023
|
|
||
| # 2nd, 3rd | ||
| nd | ||
| and |
kianmeng
force-pushed
the
fix-typos
branch
2 times, most recently
from
de988b0 to
feadffd
Compare
szepeviktor
reviewed
Dec 24, 2023
docs/spelling_wordlist.txt
Outdated
|
|
||
| # 2nd, 3rd | ||
| nd | ||
| and |
szepeviktor
reviewed
Dec 24, 2023
tests/test_cli.py
Outdated
| project_dir: str = path.abspath(path.join(gen_proj_dir, config.project_slug)) | ||
|
|
||
| # our code introduced WARNING logs due to git commit from issued to GEnerator | ||
| # our code introduced WARNING logs due to git commit from issued to GGenerator |
szepeviktor
reviewed
Dec 24, 2023
| config = user_config[user_config_yaml] | ||
|
|
||
| # the below allows URL resolutoin, same as in prod, (ie same bug should appear, if syntax error in user yaml) | ||
| # the below allows URL resolutions, same as in prod, (ie same bug should appear, if syntax error in user yaml) |
szepeviktor
reviewed
Dec 24, 2023
tests/conftest.py
Outdated
Comment on lines
+1086
to
+1088
| splitted = path.split(relative_path) | ||
| split = path.split(relative_path) | ||
|
|
||
| if splitted[0] == '': | ||
| if split[0] == '': |
szepeviktor
reviewed
Dec 24, 2023
Comment on lines
98
to
+97
| # Pytest plugin must use the legacy setuptools backend (no poetry) | ||
| # thus the setup.cfg and MANIFEST.in files are required | ||
| # Pytest pluging usually declare their public API in fixtures.py | ||
| # Pytest plugin usually declare their public API in fixtures.py |
szepeviktor
reviewed
Dec 24, 2023
| # then GEN_PROJ_LOC = /data/my-project | ||
| GEN_PROJ_LOC = os.path.realpath(os.path.curdir) | ||
|
|
||
| If we compares three flowers as pictured below |
There was a problem hiding this comment.
This non-comment line popped up here.
There was a problem hiding this comment.
Please copy this line into DeepL Write: https://www.deepl.com/write
Found via `codespell -L nd`
szepeviktor
approved these changes
Dec 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found via
codespell -L nd