Copy WAL and SHM files in legacy fallback for Firefox#237
Open
shakeyourbunny wants to merge 1 commit into
Open
Copy WAL and SHM files in legacy fallback for Firefox#237shakeyourbunny wants to merge 1 commit into
shakeyourbunny wants to merge 1 commit into
Conversation
When Firefox is running, its cookies.sqlite uses WAL mode. Recent cookies may only exist in the -wal file, not the main database. The legacy copy fallback now copies all three files (main db, WAL, SHM) so SQLite can replay the journal on the temp copy. Cleanup removes the extra files too. Fixes cookie reading from running Firefox on Windows where the readonly/immutable URI modes fail due to mandatory file locking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Firefox is running, its
cookies.sqliteuses WAL (Write-Ahead Logging) mode. Recent cookies may only exist in the-walfile, not yet checkpointed back to the main database.The legacy copy fallback currently only copies the main
.sqlitefile, so recently-set cookies are missing from the copy. On Windows this is the primary issue — the readonly/immutable URI modes fail due to mandatory file locking, the legacy copy runs, but returns stale data.This change copies all three files (
cookies.sqlite,cookies.sqlite-wal,cookies.sqlite-shm) to the temp directory so SQLite can replay the WAL journal on the temp copy. The-waland-shmcopies are best-effort — if they can't be read, the fallback still works as before with just the main db.Cleanup in
close()also removes the extra files.