test and fixes for rsync_tmbackup importer#80
Closed
hiijoshi wants to merge 2 commits intoborgbackup:masterfrom
Closed
test and fixes for rsync_tmbackup importer#80hiijoshi wants to merge 2 commits intoborgbackup:masterfrom
hiijoshi wants to merge 2 commits intoborgbackup:masterfrom
Conversation
Contributor
Author
|
Thanks for the review! I’ve updated the PR by:
All tests are passing locally. Please let me know if anything else should be improved. |
hiijoshi
force-pushed
the
add-rsync-tmbackup-test
branch
5 times, most recently
from
e41ecd8 to
764d2dc
Compare
hiijoshi
force-pushed
the
add-rsync-tmbackup-test
branch
from
764d2dc to
a6b838d
Compare
ThomasWaldmann
requested changes
Mar 25, 2026
|
|
||
| def test_rsync_tmbackup_import(tmpdir, monkeypatch): | ||
| """Test importing rsync-time-backup style snapshots into a borg repo.""" | ||
| src = Path(str(tmpdir.mkdir("tmbackup"))) |
Member
There was a problem hiding this comment.
Why is that Path(str(...)) needed?
|
|
||
| # Create archives in the source repository | ||
| subprocess.check_call(["borg", "create", f"{source_repo}::archive1", "."], cwd=str(archive1_data)) | ||
|
|
Member
There was a problem hiding this comment.
this PR is not about test_borg, so you should revert all changes to that file.
| snap2.mkdir() | ||
| (snap2 / "file1.txt").write_text("This is file 1 in snap2") | ||
|
|
||
| target_repo = Path(str(tmpdir.mkdir("target_repo"))) |
| assert any("2023-01-02" in a for a in archives) | ||
|
|
||
| # Extract and verify file contents | ||
| extract_dir = Path(str(tmpdir.mkdir("extracted"))) |
Comment on lines
+40
to
+41
| assert any("2023-01-01" in a for a in archives) | ||
| assert any("2023-01-02" in a for a in archives) |
Member
There was a problem hiding this comment.
why so complicated?
archives is a list of str, so you can just assert "2023-01-01" in archives.
Member
|
Also, if there is anything rsync_tmbackup specific you need from the other 3 PRs you opened, apply it to this one and close the other PRs. |
ThomasWaldmann
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a test for the rsync_tmbackup importer.
Changes
Reason
This extends importer test coverage using the same integration-style approach already used in the existing test suite.