Skip to content

added flushsync to opt-out of automatic batching #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edzis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

added flushsync to opt-out of automatic batching #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/google_map_markers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import React, { Component } from 'react';
import ReactDOM from 'react-dom'
import PropTypes from 'prop-types';

// utils
Expand Down Expand Up @@ -109,12 +110,15 @@ export default class GoogleMapMarkers extends Component {
const prevChildCount = (this.state.children || []).length;
const state = this._getState();

this.setState(
state,
() =>
(state.children || []).length !== prevChildCount &&
this._onMouseChangeHandler()
);
// https://github.com/google-map-react/google-map-react/issues/1102#issuecomment-1116455460
ReactDOM.flushSync(() => {
this.setState(
state,
() =>
(state.children || []).length !== prevChildCount &&
this._onMouseChangeHandler()
);
});
};

_onChildClick = () => {
Expand Down