Skip to content

Support passing --insecure-policy #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pkpbynum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support passing --insecure-policy #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/imageproxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ pub struct ImageProxyConfig {
/// If set, disable TLS verification. Equivalent to `skopeo --tls-verify=false`.
pub insecure_skip_tls_verification: Option<bool>,

/// If set, disable signature verification. Equivalent to `skopeo --insecure-policy`.
pub insecure_policy: Option<bool>,

/// Prefix to add to the user agent string. Equivalent to `skopeo --user-agent-prefix`.
/// The resulting user agent will be in the format "prefix skopeo/version".
/// This option is only used if the installed skopeo version supports it.
Expand Down Expand Up @@ -351,6 +354,10 @@ impl TryFrom<ImageProxyConfig> for Command {
c.arg("--tls-verify=false");
}

if config.insecure_policy.unwrap_or_default() {
c.arg("--insecure-policy");
}

// Add user agent prefix if provided and supported by skopeo
if let Some(user_agent_prefix) = config.user_agent_prefix {
if supports_user_agent_prefix() {
Expand Down Expand Up @@ -902,6 +909,13 @@ mod tests {
.unwrap();
validate(c, &[r"--tls-verify=false"], &[]);

let c = Command::try_from(ImageProxyConfig {
insecure_policy: Some(true),
..Default::default()
})
.unwrap();
validate(c, &[r"--insecure-policy"], &[]);

let mut tmpf = cap_tempfile::TempFile::new_anonymous(tmpd).unwrap();
tmpf.write_all(r#"{ "auths": {} "#.as_bytes()).unwrap();
tmpf.seek(std::io::SeekFrom::Start(0)).unwrap();
Expand Down