ostree-ext: Keep CAP_DAC_READ_SEARCH when passing auth via fd#2303
Open
gursewak1997 wants to merge 1 commit into
Open
ostree-ext: Keep CAP_DAC_READ_SEARCH when passing auth via fd#2303gursewak1997 wants to merge 1 commit into
gursewak1997 wants to merge 1 commit into
Conversation
When running under systemd, ostree-ext drops privileges to 'nobody' with setpriv --bounding-set -all. However, skopeo needs to re-open auth file descriptors at /proc/self/fd/N, which requires CAP_DAC_READ_SEARCH. Fix by conditionally keeping this capability when auth_data is present: setpriv --bounding-set -all,+dac_read_search This fixes Anaconda installations with authenticated registries while maintaining security (still runs as unprivileged user). Signed-off-by: gursewak1997 <gursmangat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running under systemd, ostree-ext drops privileges to 'nobody' with setpriv --bounding-set -all. However, skopeo needs to re-open auth file descriptors at /proc/self/fd/N, which requires CAP_DAC_READ_SEARCH.
Fix by conditionally keeping this capability when auth_data is present: setpriv --bounding-set -all,+dac_read_search
This fixes Anaconda installations with authenticated registries while maintaining security (still runs as unprivileged user).