build.jam: fix malformed alias so b2 install generates cmake config#74
Open
jll63 wants to merge 1 commit into
Open
build.jam: fix malformed alias so b2 install generates cmake config#74jll63 wants to merge 1 commit into
jll63 wants to merge 1 commit into
Conversation
|
An automated preview of the documentation is available at https://74.openmethod.prtest3.cppalliance.org/libs/openmethod/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-05-25 00:45:42 UTC |
Two problems prevented `b2 install` from producing `lib/cmake/boost_openmethod-<version>/boost_openmethod-config.cmake`, breaking downstream consumers that use `find_package(Boost CONFIG REQUIRED COMPONENTS openmethod)` (and the unified-cmake CI job): 1. The `boost_openmethod` alias used `usage-requirements` as a literal source name instead of the 5th argument position, and lived outside the `explicit` block. Move it inside `explicit` and put `<include>include <library>$(boost_dependencies)` in the usage-requirements slot, matching `assert`, `core`, `mp11`, `preprocessor`, etc. 2. The `call-if : boost-library openmethod` invocation had no `install` option, so the Jamroot fallback path declared empty install targets and `install-cmake-config` was called with no library names — no config files were generated. Add `: install boost_openmethod` so the library name reaches `install-or-stage-cmake-config`. Verified locally on Windows: `b2 install` now produces `lib/cmake/boost_openmethod-1.92.0/boost_openmethod-config.cmake` (and the matching `-config-version.cmake`) defining `Boost::openmethod`. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #74 +/- ##
===========================================
- Coverage 94.34% 93.27% -1.07%
===========================================
Files 43 41 -2
Lines 2916 2811 -105
===========================================
- Hits 2751 2622 -129
- Misses 165 189 +24 see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build.jamdeclares theboost_openmethodalias withusage-requirementswritten as a literal source name and the alias placed outside theexplicitblock. Theboost-library openmethodrule then cannot detect the library's interface, andb2 installskips the cmake config files for openmethod.This breaks downstream consumers that call
find_package(Boost CONFIG REQUIRED COMPONENTS openmethod)against a b2-installed Boost — including the unified-cmake CI job on Windows, which currently fails with:Fix
Move the alias inside
explicitand put<include>include <library>$(boost_dependencies)in the proper usage-requirements slot (the 5th colon-separated argument). This matches the pattern used by every other header-only Boost library (assert,core,describe,mp11,preprocessor, ...).Test plan
b2 installproduces<prefix>/lib/cmake/boost_openmethod-<version>/boost_openmethod-config.cmakefind_package(Boost CONFIG REQUIRED COMPONENTS openmethod)succeeds against a b2-installed Boost