Skip to content

Conversation

@JacobHass8
Copy link

See #1305 for for details.

@JacobHass8
Copy link
Author

@dschmitz89 how does this first commit look in regards to #1338 (comment)

@JacobHass8 JacobHass8 changed the title Initial implementation of find_non_centrality for non_central_f_distribution [skip ci] Initial implementation of find_non_centrality for non_central_f_distribution Dec 28, 2025
@dschmitz89
Copy link
Contributor

Thanks @JacobHass8 for looking into this so quickly. This is a good start. I am not a boost maintainer (barely a boost developer), so can only comment from a high level.

The most important missing bit here is tests for the new functionality. I could not find the current noncentral F distribution tests after 2 minutes though, so we will have to rely on the boost devs to guide us a little here.

@jzmaddock
Copy link
Collaborator

Yup, tests needed.

Non central F is treated as a special case of the non-central beta (which is where most of the tests are). Non-central F tests are fairly lightweight, just there to make sure we have the transformation to non-central beta correct really: https://github.com/boostorg/math/blob/develop/test/test_nc_f.cpp. A similar level of sanity checking would probably suffice for this function I would guess?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants