Fix degenerate linestring relation on boundary of areal#1474
Open
mjacobse wants to merge 3 commits into
Open
Conversation
| update<boundary, interior, '0', TransposeResult>(m_result); | ||
| m_interrupt_flags |= 4; | ||
| } | ||
| else |
Collaborator
There was a problem hiding this comment.
Should we handle pig == 0 here too?
Contributor
Author
There was a problem hiding this comment.
A degenerate linestring does not have a boundary itself, so this case shouldn't be possible I believe.
Collaborator
|
Thanks for the PR, is it a bit larger than earlier? Anyway, that's not a problem, will continue the review later |
Contributor
Author
Adding the handling of the interrupt flags for this case now made it a bit bigger yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically makes it so
covered_byreturnstrueforLINESTRING(0 0,0 0)andPOLYGON((0 0, 0 2, 2 2, 2 0, 0 0))instead offalseas it did previously, which could be quite surprising.Fixes #1473
The bit flags for interrupt aren't exactly pretty, but it follows the present implementation.