Add overlay regression case for issue 1439 #1444
Conversation
|
This PR adds the overlay regression case for issue #1439. |
| "POLYGON((0 7,-5 6,11 -13,0 7))" | ||
| }; | ||
|
|
||
| // Issue 1439: non-overlapping polygons reported as full intersection |
There was a problem hiding this comment.
But it is not called yet? Or do you still have to push something?
There was a problem hiding this comment.
You’re right — the case was not called yet.
I’ve now added an overlay intersection test in overlay.cpp for case_1439
using TEST_INTERSECTION, wrapped in
BOOST_GEOMETRY_TEST_ENABLE_FAILING,
and pushed the update to this PR.
There was a problem hiding this comment.
Hi! Thanks for the review 👍
Just checking if there’s anything else I should update before this can be merged.
There was a problem hiding this comment.
It's fine now. I added @vissarion and @tinko92 for short optional additional reviews.
I will look tomorrow at the case itself, and get back to you.
Thanks again for your quick efforts.
vissarion
left a comment
vissarion
left a comment
There was a problem hiding this comment.
I am OK, I left only some minor comments. Thanks @kashish2710 !
Feel free to merge your commits into one. In any case we can still squash merge the PR.
test/algorithms/overlay/overlay.cpp
Outdated
| #ifdef BOOST_GEOMETRY_TEST_ENABLE_FAILING | ||
| // Issue 1439 | ||
| // Regression test: intersection of non-overlapping polygons should be empty. | ||
| TEST_INTERSECTION(case_1439, 0, 0, 0.0); |
There was a problem hiding this comment.
maybe issue_1439 is more descriptive
test/algorithms/overlay/overlay.cpp
Outdated
|
|
||
| #ifdef BOOST_GEOMETRY_TEST_ENABLE_FAILING | ||
| // Issue 1439 | ||
| // Regression test: intersection of non-overlapping polygons should be empty. |
|
Thanks @vissarion for the review and suggestions! |
4 participants
This PR adds a regression test case for Boost.Geometry issue #1439.
– Introduces case_1439 in overlay_cases.hpp
– The case represents two non-overlapping polygons
– This case is intended to be used by set operation tests
No algorithm behavior is changed; this only adds test data.