Use core::string_view directly instead of alias by ssam18 · Pull Request #3058 · boostorg/beast

ssam18 · 2025-11-18T01:53:57Z

This PR addresses issue #3046 by replacing all uses of the string_view alias with core::string_view throughout the codebase for improved clarity in both documentation and source code.

Changes

Replaced string_view with core::string_view in all header files (.hpp)
Replaced string_view with core::string_view in all inline implementation files (.ipp)
Updated documentation files (.qbk) to use core::string_view
Replaced basic_string_view with core::basic_string_view where applicable
Retained type aliases in string_type.hpp for backward compatibility

Benefits

Makes it explicit that Beast uses boost::core::string_view
Improves code clarity and documentation
Easier for users to understand the library's dependencies

Files Modified

48 header and implementation files
4 documentation files
Total: 52 files with 410 insertions and 347 deletions

Closes #3046

cppalliance-bot · 2025-11-18T02:03:26Z

An automated preview of the documentation is available at https://3058.beast.prtest.cppalliance.org/libs/beast/doc/html/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-04-02 14:32:41 UTC

codecov · 2025-11-18T03:19:36Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.29%. Comparing base (a74967f) to head (b5ce94e).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3058   +/-   ##
========================================
  Coverage    93.29%   93.29%           
========================================
  Files          177      177           
  Lines        13742    13742           
========================================
  Hits         12821    12821           
  Misses         921      921

Files with missing lines	Coverage Δ
example/doc/http_examples.hpp	`80.36% <100.00%> (ø)`
...ude/boost/beast/_experimental/test/impl/stream.ipp	`98.36% <ø> (ø)`
include/boost/beast/_experimental/test/stream.hpp	`75.00% <ø> (ø)`
.../boost/beast/core/detail/impl/temporary_buffer.ipp	`100.00% <ø> (ø)`
include/boost/beast/core/detail/string.hpp	`100.00% <100.00%> (ø)`
...clude/boost/beast/core/detail/temporary_buffer.hpp	`100.00% <ø> (ø)`
include/boost/beast/core/impl/string.ipp	`100.00% <ø> (ø)`
include/boost/beast/core/string_type.hpp	`100.00% <100.00%> (ø)`
include/boost/beast/http/basic_parser.hpp	`94.11% <ø> (ø)`
include/boost/beast/http/chunk_encode.hpp	`100.00% <ø> (ø)`
... and 30 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a74967f...b5ce94e. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ashtum · 2025-11-18T05:17:44Z

Thank you. Could you please check the example and test directories as well?

replace_string_view.py

vinniefalco · 2025-11-18T07:30:15Z

This is great!

ssam18 · 2025-11-18T14:23:18Z

Thank you @ashtum for the review! I've updated the PR to:

Process example and test directories - added 58 more files with string_view replacements
Remove replace_string_view.py from the committed files

include/boost/beast/core/string_type.hpp

.gitignore

doc/qbk/04_http/08_chunked_encoding.qbk

doc/qbk/08_design/1_http_message.qbk

ssam18 · 2025-11-18T15:46:03Z

Thank you for the detailed review! I've addressed all the feedback:

Removed the type aliases from string_type.hpp as they're no longer needed since all code now uses core::string_view directly
Removed the .gitignore entry for replace_string_view.py

include/boost/beast/http/parser.hpp

ssam18 · 2025-11-18T16:25:58Z

Fixed all remaining comment alignment issues.

ashtum · 2025-11-18T17:08:45Z

@ssam18 You can use the GitHub Action CI in your own fork to address the compile errors, since it won’t require approval to run each time.

Use fully qualified boost::core::string_view instead of core::string_view or beast::string_view to ensure correct namespace resolution in nested boost::beast namespace contexts. This fixes compilation errors across all platforms where the compiler was looking for non-existent types like boost::beast::core::string_view. Fixes CI compilation failures in PR boostorg#3058.

example/doc/http_examples.hpp

test/doc/http_10_custom_parser.cpp

test/beast/websocket/read3.cpp

ssam18 · 2025-11-18T23:41:01Z

Why the core::string_view → boost::core::string_view change is necessary?

The issue:

C++ namespace lookup rules mean that when you write core::string_view in a file, the compiler searches for core starting from the current namespace and working outward. This works fine in files already inside namespace boost { ... } because the compiler finds boost::core. But in standalone example and test files that aren't wrapped in the boost namespace, the compiler can't find core at all.

FIX:

Files need to use the fully qualified name boost::core::string_view unless they're already inside the boost namespace. This is why:

Example files (like example/http/server/async/http_server_async.cpp) → Need boost::core::string_view (standalone programs)
Test/doc files outside boost namespace → Need boost::core::string_view
Header files inside namespace boost (like example/doc/http_examples.hpp) → Can use core::string_view (already in boost namespace)
This is standard C++ namespace behavior—you need the full qualification when you're not already in the parent namespace. The changes ensure MSVC (and all other compilers) can properly resolve the type regardless of where it's used.

include/boost/beast/http/impl/verb.ipp

doc/qbk/release_notes.qbk

test/doc/core_1_refresher.cpp

ssam18 · 2025-11-30T15:04:43Z

@ashtum Please let me know if this PR looks good?

ashtum · 2025-11-30T15:49:02Z

@ashtum Please let me know if this PR looks good?

All files under test/doc and example should use core::string_view rather than boost::string_view.
If needed, add namespace core = boost::core; in the correct location, following the style of nearby using declarations.

For example:

namespace beast = boost::beast;          // from <boost/beast.hpp>
namespace http = beast::http;            // from <boost/beast/http.hpp>
namespace websocket = beast::websocket;  // from <boost/beast/websocket.hpp>
namespace net = boost::asio;             // from <boost/asio.hpp>
namespace ssl = boost::asio::ssl;        // from <boost/asio/ssl.hpp>
namespace core = boost::core;            // from <boost/core/detail/string_view.hpp>
using tcp = boost::asio::ip::tcp;        // from <boost/asio/ip/tcp.hpp>

Please review each changed line manually and use your judgment to fix any formatting, clarity, or semantic issues.
Please run the CI on your branch and address the build failures (you need to activate GHA action for your fork).

example/advanced/server-flex/advanced_server_flex.cpp

example/http/server/async-local/http_server_async_local.cpp

test/doc/exemplars.cpp

test/doc/http_10_custom_parser.cpp

Use fully qualified boost::core::string_view instead of core::string_view or beast::string_view to ensure correct namespace resolution in nested boost::beast namespace contexts. This fixes compilation errors across all platforms where the compiler was looking for non-existent types like boost::beast::core::string_view. Fixes CI compilation failures in PR boostorg#3058.

Replaced all uses of string_view and basic_string_view with core::string_view and core::basic_string_view respectively throughout the codebase. Closes boostorg#3046

Use fully qualified boost::core::string_view instead of core::string_view or beast::string_view to ensure correct namespace resolution in nested boost::beast namespace contexts. This fixes compilation errors across all platforms where the compiler was looking for non-existent types like boost::beast::core::string_view. Fixes CI compilation failures in PR boostorg#3058.

This fixes macOS compilation errors where the compiler couldn't resolve the unqualified string_view type in iterator declarations.

…ing_view

…ace and fix comment alignment

…tring_view The test/doc files are not inside the boost namespace, so they need the fully qualified boost::core::string_view instead of core::string_view. Changed back to boost::core::string_view in all affected test/doc files.

…ring_view Example files are standalone programs not inside the boost namespace, so they require the fully qualified boost::core::string_view. Updated all example files except those in example/doc/ which are already inside the boost namespace.

Remove boost:: prefix from core::string_view in implementation files (.ipp) where code is already inside the boost namespace. This makes the code cleaner and follows the project's namespace usage conventions. Also reverted unintended change to release notes as requested by maintainer. Signed-off-by: Samaresh Kumar Singh <ssam3003@gmail.com>

Replace boost::core::string_view with core::string_view throughout example and test/doc directories. Add namespace alias declarations 'namespace core = boost::core;' following project style guidelines.

…path comments

- Add `namespace core = boost::core;` to test/fuzz files that used `core::string_view` without it being in scope (compilation failure) - Revert release_notes.qbk change (reviewers: please don't modify that) - Fix comment style: `// <boost/core/detail/string_view.hpp>` → `// from <boost/beast.hpp>` in all test/doc and example files - Move `namespace core` before `using tcp` declarations in example files where it was incorrectly placed after - Fix alignment of `namespace core` comment to match surrounding lines

write_string() uses core::string_view at doc_core_snippets namespace scope, but namespace core was only declared inside fxx(). namespace net works globally because config.hpp defines it at global scope; core needs an equivalent declaration. Add it at file scope alongside the existing using namespace boost::beast.

libs/regex depends on libs/static_assert via Boost.Build, but it was missing from the Windows CI submodule checkout, causing all MSVC builds to fail with 'could not resolve project reference /boost/static_assert'.

ssam18 · 2026-04-02T15:50:26Z

@vinniefalco vinniefalco after a long chase, I was able to fix all the failing tests after addressing the review comments. Please take a look at this PR.