Node 22 and Azure Functions v4 migration by MarcAstr0 · Pull Request #1593 · boostercloud/booster

MarcAstr0 · 2026-01-30T16:11:31Z

Description

This PR adds Node 22 support for Booster. Booster 3.x works with Node 20, which is reaching EOL in April 2026. In the case of Azure, switching to Node 22 requires upgrading the Azure Functions runtime from v3 to v4. Version 4 introduces an imperative approach instead of a declarative one—functions are now defined programmatically in a functions.js file rather than the function.json files used in v3.

Another major change in the v4 @azure/functions SDK is the context type used in function requests (Context → InvocationContext). Wrappers were created for the different types of function requests.

Changes

Updated framework-provider-azure-infrastructure package to generate v4-compatible Azure Functions
Updated framework-provider-azure to work with the v4 @azure/functions SDK
Updated dependencies across all packages to support Node 22
Updated CI/CD actions and workflows for Node 22 compatibility
Added migration guide to documentation

Checks

Project Builds
Project passes tests and checks
Updated documentation accordingly

Additional information

Rockets targeting Azure infrastructure must be updated to implement mountFunctionsV4 instead of the now-deprecated mountCode and mountFunctions methods. See the migration guide for details.

- Bump Node.js from v20 (Iron) to v22 (Jod) LTS - Update Rush from 5.133.4 to 5.166.0 - Update nodeSupportedVersionRange to >=22.0.0 <23.0.0 - Update engine requirements across all packages

- Define type wrappers, guards, and helpers for v4 programming model (HTTP, CosmosDB, EventHub, Timer, Web PubSub) - Export types from main package entry point

- Update adapters to use v4 InvocationContext and HttpResponseInit - Add type definitions, guards, and helpers for all trigger types - Fix parameter property syntax in tests for Node 22 compatibility

This reverts commit ca34a18.

packages/framework-provider-azure-infrastructure/src/infrastructure/index.ts

MarcAstr0 · 2026-01-30T16:29:51Z

/integration sha=22a37ba

github-actions · 2026-01-30T16:30:08Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2026-01-30T17:11:30Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2026-01-30T18:09:09Z

/integration sha=39b572a

github-actions · 2026-01-30T18:09:25Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2026-01-30T18:12:40Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2026-01-30T18:14:32Z

/integration sha=9d6ec78

github-actions · 2026-01-30T18:14:47Z

⌛ Integration tests are running...

Check their status here 👈

- Bump validator 13.12.0 → 13.15.26, mock-jwks 1.0.3 → 1.0.10 - Add pnpm overrides in .pnpmfile.cjs for transitive vulns - Fix TS7053 in http-service.ts (RequestOptions.headers union type) - Update token verifier tests for jsonwebtoken 9.x iat claim

github-actions · 2026-01-30T19:06:14Z

❌ Oh no! Integration tests have failed

MarcAstr0 · 2026-01-30T19:15:06Z

/integration sha=9235aca

github-actions · 2026-01-30T19:15:21Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2026-01-30T20:10:19Z

✅ Integration tests have finished successfully!

MarcAstr0 · 2026-02-04T21:52:35Z

/integration sha=ca63936

MarcAstr0 · 2026-02-11T20:33:03Z

/integration sha=2899da1

github-actions · 2026-02-11T20:33:20Z

⌛ Integration tests are running...

Check their status here 👈

Copilot

Pull request overview

Copilot reviewed 70 out of 72 changed files in this pull request and generated 14 comments.

Files not reviewed (1)

website/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

upgrade-v4.md

packages/framework-provider-azure/.mocharc.yml

packages/framework-provider-local-infrastructure/.mocharc.yml

packages/framework-provider-local/.mocharc.yml

common/config/rush/.pnpmfile.cjs

packages/framework-provider-azure-infrastructure/src/infrastructure/rockets/rocket-builder.ts

packages/framework-core/.mocharc.yml

packages/framework-common-helpers/.mocharc.yml

packages/cli/.mocharc.yml

packages/framework-provider-azure/test/helpers/event-helper.ts

github-actions · 2026-02-11T21:27:03Z

✅ Integration tests have finished successfully!

alvaroloes

claude: ## Node 22 + Azure Functions v4 Migration — Code Review Summary

Overall, this is a solid and well-structured migration. The v3→v4 adapter rewrites are clean, the new type guards in azure-func-types.ts are well-written, and the rocket backward-compat via mountFunctionsV4 alongside deprecated mountCode/mountFunctions is thoughtful. The Web PubSub hub post-deploy update (replacing shell-based curl/az CLI with Azure SDK) is a good improvement.

🔴 Issues to address before merge

.mocharc.yml — missing -- prefix (see inline comment)
no-experimental-strip-types needs to be --no-experimental-strip-types. Without the prefix, Node ignores it and the experimental TS stripping stays active — tests may pass for wrong reasons.
scheduled-adapter.ts — isScheduledCommandInput doesn't validate typeName (see inline comment)
The type guard only checks isTimerFunctionInput() but ScheduledCommandInput extends it with a typeName field. Any timer input will pass, even if it's missing typeName.
pnpmfile.cjs — unbounded security overrides (see inline comment)
minSafe ranges like '>=4.0.4' are unbounded upward and will match future major versions — contradicting the intent on L38.
rocket-builder.ts — functionAppName sanitization may break Kudu deploy URLs
.replace(/(\W+)/gi, '_') converts dashes to underscores, but Azure Function App names use dashes. The sanitized name is used for Kudu deployment URLs (https://${functionAppName}.scm.azurewebsites.net), which would target a non-existent app if the real name has dashes.
booster-token-verifier.test.ts — deepEqual → include weakens assertions
Changing .to.deep.equals() to .to.deep.include() means the test will pass even if user.claims has extra unexpected properties. If the migration doesn't change claim shapes, the original strict assertion should be preserved. If Node 22 adds extra claim fields, prefer updating the expected object rather than loosening the check.

🟡 Minor issues

events-adapter.ts — typo in error message (see inline comment): AzureCosmosDBFunctioninput → AzureCosmosDBFunctionInput
azure-func-types.ts — JSDoc typo (see inline comment): objetc → object on L11

✅ What looks good

Type guards (isHttpFunctionInput, isCosmosDBFunctionInput, etc.) are well-implemented with proper null checks and property existence validation
- Adapter rewrites (api-adapter.ts, health-adapter.ts, read-model-adapter.ts, subscription-model.ts) correctly migrate from Context to InvocationContext + typed inputs
- - booster-graphql-dispatcher.ts — the X-Booster-WebSocket-Message header addition is clean and backward-compatible
- - - http-service.ts — conditional Content-Length header is correct
- - - - upgrade-v4.md migration guide is helpful
- - - - Terraform Web PubSub hub lifecycle.ignoreChanges pattern is appropriate for post-deploy managed resources
- - - - Rush/pnpm tooling version bumps look correct

packages/framework-core/.mocharc.yml

packages/framework-provider-azure/src/library/scheduled-adapter.ts

common/config/rush/.pnpmfile.cjs

packages/framework-provider-azure/src/library/events-adapter.ts

packages/framework-provider-azure/src/types/azure-func-types.ts

alvaroloes

codex: Revisión completada. He dejado 3 comentarios inline enfocados en riesgos no cubiertos por revisiones previas: 1) deploy que puede terminar en verde con subscriptions rotas si no aparece webpubsub_extension; 2) inconsistencia disconnect/disconnected que puede impedir el path correcto de desconexión; 3) logging excesivo de payload/metadata en connect con riesgo de exponer datos sensibles y aumentar ruido operativo. Recomiendo resolverlos antes de merge.

packages/framework-provider-azure-infrastructure/src/infrastructure/index.ts

...ramework-provider-azure-infrastructure/src/infrastructure/helper/functions-code-generator.ts

MarcAstr0 · 2026-02-12T14:52:49Z

@alvaroloes about this comment: the suggested check is redundant because TypeScript already knows that typeName is a string based on the type narrowing from isTimerFunctionInput.

MarcAstr0 · 2026-02-12T17:05:28Z

/integration sha=1185227c

github-actions · 2026-02-12T17:05:49Z

⌛ Integration tests are running...

Check their status here 👈

github-actions · 2026-02-12T18:00:35Z

✅ Integration tests have finished successfully!

Copilot

Pull request overview

Copilot reviewed 70 out of 72 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

website/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...er-azure-infrastructure/src/infrastructure/synth/web-pubsub-extension-key/terraform-sleep.ts

.nvmrc

packages/framework-provider-azure/src/library/api-adapter.ts

packages/framework-core/test/booster-token-verifier.test.ts

Castro, Mario added 10 commits January 29, 2026 12:10

Upgrade Node.js to v22 LTS and update Rush tooling

daefadd

- Bump Node.js from v20 (Iron) to v22 (Jod) LTS - Update Rush from 5.133.4 to 5.166.0 - Update nodeSupportedVersionRange to >=22.0.0 <23.0.0 - Update engine requirements across all packages

Upgrade Node.js to v22 LTS in fixtures

5b75e7c

Add Azure Functions v4 types and export them

49c8638

- Define type wrappers, guards, and helpers for v4 programming model (HTTP, CosmosDB, EventHub, Timer, Web PubSub) - Export types from main package entry point

Migrate Azure provider to Functions v4 programming model

b68675e

- Update adapters to use v4 InvocationContext and HttpResponseInit - Add type definitions, guards, and helpers for all trigger types - Fix parameter property syntax in tests for Node 22 compatibility

Fix strip-only issue in framework-types package

ca34a18

Revert "Fix strip-only issue in framework-types package"

69d8ef2

This reverts commit ca34a18.

Fix Node 22-related issues in unit tests

4c9b0bf

Migrate Azure infra provider to Node 22 and Azure Functions v4

ef6a6dc

Change CI/CD actions and workflows to use Node 22

e79b772

Add rush change file

255a2b7

github-advanced-security bot found potential problems Jan 30, 2026

View reviewed changes

Update lock file

22a37ba

Castro, Mario added 2 commits January 30, 2026 15:05

Fix broken CLI integration test

39b572a

Merge remote-tracking branch 'origin/node_22' into node_22

9d6ec78

Castro, Mario and others added 2 commits January 30, 2026 15:59

Fix typos

5aca0b7

Add Functions v4 support for rockets

ca63936

Castro, Mario and others added 4 commits February 11, 2026 14:44

Fix typos

e22bc23

Refactor Web PubSub update during deployment

f7388d1

Refactor Web PubSub update during deployment

e1936df

Update lock file

2899da1

MarcAstr0 requested a review from Copilot February 11, 2026 20:30

Copilot started reviewing on behalf of MarcAstr0 February 11, 2026 20:30 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

alvaroloes reviewed Feb 12, 2026

View reviewed changes

alvaroloes requested changes Feb 12, 2026

View reviewed changes

Fix minor typos

8829be6

Castro, Mario added 5 commits February 12, 2026 11:55

Merge remote-tracking branch 'origin/node_22' into node_22

722acfe

Fix minor typos

ed93f6c

Add upper bounds to dependency security overrides

fb9ac49

Remove logs with potentially sensitive data

24ef535

Add error for webpubsub_extension not found

1185227

MarcAstr0 requested review from alvaroloes and Copilot February 12, 2026 18:21

Copilot started reviewing on behalf of MarcAstr0 February 12, 2026 18:21 View session

Copilot AI reviewed Feb 12, 2026

View reviewed changes

alvaroloes approved these changes Feb 16, 2026

View reviewed changes

MarcAstr0 merged commit fcbae22 into boostercloud:main Feb 17, 2026
12 checks passed

This was referenced Mar 6, 2026

Node 22 and Azure Functions v4 migration boostercloud/rocket-file-uploads#21

Open

Node 22 and Azure Functions v4 migration boostercloud/rocket-webhook#13

Open

Conversation

MarcAstr0 commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Checks

Additional information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MarcAstr0 commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

MarcAstr0 commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

MarcAstr0 commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

MarcAstr0 commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

github-actions bot commented Jan 30, 2026

Uh oh!

MarcAstr0 commented Feb 4, 2026

Uh oh!

MarcAstr0 commented Feb 11, 2026

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 11, 2026

Uh oh!

alvaroloes left a comment

Choose a reason for hiding this comment

🔴 Issues to address before merge

🟡 Minor issues

✅ What looks good

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alvaroloes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

MarcAstr0 commented Feb 12, 2026

Uh oh!

MarcAstr0 commented Feb 12, 2026

Uh oh!

github-actions bot commented Feb 12, 2026

MarcAstr0 commented Jan 30, 2026 •

edited

Loading