Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import _ "github.com/bool64/dev" // Include development helpers to project.
Add `Makefile` to your module with includes standard targets.

```Makefile
#GOLANGCI_LINT_VERSION := "v1.63.4" # Optional configuration to pinpoint golangci-lint version.
#GOLANGCI_LINT_VERSION := "v1.64.5" # Optional configuration to pinpoint golangci-lint version.

# The head of Makefile determines location of dev-go to include standard targets.
GO ?= go
Expand Down
2 changes: 1 addition & 1 deletion makefiles/base.mk
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#GOLANGCI_LINT_VERSION := "v1.63.4" # Optional configuration to pinpoint golangci-lint version.
#GOLANGCI_LINT_VERSION := "v1.64.5" # Optional configuration to pinpoint golangci-lint version.

# The head of Makefile determines location of dev-go to include standard targets.
GO ?= go
Expand Down
15 changes: 0 additions & 15 deletions scripts/.golangci-internal.yml

This file was deleted.

6 changes: 2 additions & 4 deletions scripts/.golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ linters-settings:
threshold: 100
misspell:
locale: US
unused:
check-exported: false
unparam:
check-exported: true

linters:
enable-all: true
disable:
- intrange
- copyloopvar
- lll
- gochecknoglobals
- wrapcheck
Expand All @@ -36,7 +36,6 @@ linters:
- dupword
- depguard
- tagalign
- execinquery
- mnd
- testifylint
- recvcheck
Expand All @@ -50,7 +49,6 @@ issues:
- noctx
- funlen
- dupl
- structcheck
- unused
- unparam
path: "_test.go"
Expand Down
7 changes: 1 addition & 6 deletions scripts/lint.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash

[ -z "$GO" ] && GO=go
[ -z "$GOLANGCI_LINT_VERSION" ] && GOLANGCI_LINT_VERSION="v1.63.4"
[ -z "$GOLANGCI_LINT_VERSION" ] && GOLANGCI_LINT_VERSION="v1.64.5"

# detecting GOPATH and removing trailing "/" if any
GOPATH="$(go env GOPATH)"
Expand All @@ -25,8 +25,3 @@ fi

echo "Checking packages."
golangci-lint-"$GOLANGCI_LINT_VERSION" run -c "$golangci_yml" ./... || exit 1

if [[ -d "./internal" && -d "./cmd" ]]; then
echo "Checking unused exported symbols in internal packages."
golangci-lint-"$GOLANGCI_LINT_VERSION" run -c "$this_path"/.golangci-internal.yml ./internal/... ./cmd/... || exit 1
fi
4 changes: 2 additions & 2 deletions templates/github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
go-version: stable
- uses: actions/checkout@v4
- name: golangci-lint
uses: golangci/golangci-lint-action@v6.2.0
uses: golangci/golangci-lint-action@v6.5.0
with:
# Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
version: v1.63.4
version: v1.64.5

# Optional: working directory, useful for monorepos
# working-directory: somedir
Expand Down
Loading