This repository was archived by the owner on May 3, 2022. It is now read-only.
No release tag in built deployment files #233
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the behavior of the makefile and removes the release tag from file names. This is mainly done to preserve a deterministic path to shipper deploy file which is promoited in the documentation under latest tag. A static deployment file name allows one to link it with no need to update the relevant documentation on every build. Signed-off-by: Oleg Sidorov <oleg.sidorov@booking.com>
juliogreff
suggested changes
Nov 22, 2019
Contributor
juliogreff
left a comment
juliogreff
left a comment
There was a problem hiding this comment.
A couple of very small changes:
- Might as well stop using
$(IMAGE_TAG)in the*.imagefiles as well, since the tag was there just to support the yamls anyway. - There's an
rm -f build/*.latest.yamlinci/e2e.shthat's now redundant.
Also, ci/release.sh was expected to re-build images with different tags from the ones generated by ci/e2e.sh. I have not tested this, but it might not re-tag the images anymore, and instead might push images tagged with a commit id instead of the git tag as expected. If that's the case, one possible solution is to force, in ci/e2e.sh, IMAGE_TAG to be $TRAVIS_TAG if set, or $TRAVIS_COMMIT otherwise.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the behavior of the makefile and removes the
release tag from file names. This is mainly done to preserve a
deterministic path to shipper deploy file which is promoited in the
documentation under latest tag. A static deployment file name allows one
to link it with no need to update the relevant documentation on every
build.
Signed-off-by: Oleg Sidorov oleg.sidorov@booking.com