fix SummarizeValues#534
Merged
deniszh merged 6 commits intobookingcom:masterfrom Jan 21, 2026
Merged
Conversation
Add parameter "absent" to func SummarizeValues and ignore absent values when calculating the average, min, last or count values.
spacefreak86
requested review from
azhiltsov,
deniszh,
emadolsky,
grzkv and
timtofan
as code owners
Contributor
|
@grzkv @emadolsky : could you please also review? |
deniszh
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #533 (wrong last value being shown in legend) and also corrects the calculation of the average, min, last and count values.
By adding the parameter
absenttoSummarizeValues, it is now able to correctly account for absent values.Logically all calls to SummarizeValues also had to be adapted.