Merged
Conversation
`src/cli/handlers.ts`: Replaced nested ternary with readable switch statement for signal exit codes `src/cli/commands/baseline.ts`: Removed duplicate formatDuration and formatOpsPerSec functions, now imports from shared utils `src/cli/commands/history.ts`: Removed duplicate formatBytes function, now imports from shared utils `src/errors/base.ts`: Consolidated isError type guard to use the one in `type-guards.ts`
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates duplicate utility functions and improves code readability through refactoring.
Key Changes:
- Consolidated the
isErrortype guard by removing duplicate fromsrc/errors/base.tsand using the shared implementation fromsrc/utils/type-guards.ts - Replaced a nested ternary operator with a more readable switch statement for computing signal exit codes
- Removed duplicate formatting functions (
formatBytes,formatDuration,formatOpsPerSec) from command files, now importing from sharedreporter-utils.ts
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/errors/base.ts | Removes duplicate isError type guard, imports from shared type-guards.ts |
| src/cli/handlers.ts | Replaces nested ternary with switch statement for signal exit codes; updates isError import |
| src/cli/commands/history.ts | Removes duplicate formatBytes function, imports from shared reporter-utils.ts |
| src/cli/commands/baseline.ts | Removes duplicate formatDuration and formatOpsPerSec functions, imports from shared reporter-utils.ts; updates function name to formatOpsPerSecond |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/cli/handlers.ts: Replaced nested ternary with readable switch statement for signal exit codessrc/cli/commands/baseline.ts: Removed duplicate formatDuration and formatOpsPerSec functions, now imports from shared utilssrc/cli/commands/history.ts: Removed duplicate formatBytes function, now imports from shared utilssrc/errors/base.ts: Consolidated isError type guard to use the one intype-guards.ts