Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Node.js v20 support to the CI pipeline. Since Node.js v20's native node --test command doesn't support glob patterns, a custom test runner script is introduced to work around this limitation.
Key Changes:
- Created a custom test runner script that uses the
globpackage to find test files and pass them to Node.js v20's test runner - Enabled Node.js v20 in the GitHub Actions test matrix with conditional execution logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/run-tests-v20.js | New test runner script that resolves glob patterns for Node.js v20's test command |
| .github/workflows/nodejs.yml | Uncommented Node.js v20 from the test matrix and added conditional test steps to use the custom runner for v20 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
boneskull
force-pushed
the
boneskull/nodejs-20-ci
branch
from
f236186 to
a8cd19d
Compare
boneskull
force-pushed
the
boneskull/nodejs-20-ci
branch
from
a8cd19d to
5358223
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
boneskull
force-pushed
the
boneskull/nodejs-20-ci
branch
3 times, most recently
from
235ee40 to
a80b5ec
Compare
chore(ci): add Node.js 20 support for CI - Add runtime check for profiling limitation on Node.js 20 (--cpu-prof not allowed in NODE_OPTIONS for security reasons) - Show helpful error message directing users to Node.js 22+ - Fix run-tests-v20.js to use process.execPath instead of 'node' - Add isNode20 helper to test/util.ts for version-specific test skipping - Split profiling tests into Node 20 and Node 22+ groups 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Per review feedback, moved the JSDoc module documentation to come after all import statements. Note: kept import ordering per project's perfectionist ESLint config (alphabetical), not the Node.js builtin-first convention suggested by the reviewer. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
boneskull
force-pushed
the
boneskull/nodejs-20-ci
branch
from
a80b5ec to
7433789
Compare
No description provided.