fix: withTrim caches wrapper functions via WeakMap (fixes #8)#18
Open
handsomesix wants to merge 2 commits into
Open
fix: withTrim caches wrapper functions via WeakMap (fixes #8)#18handsomesix wants to merge 2 commits into
handsomesix wants to merge 2 commits into
Conversation
This addresses issue bogeeee#8: withTrim no longer creates a new function instance on every call. Instead, it reuses the same wrapper for identical (callbackFn, useSignatureFrom) pairs, enabling use with addEventListener/removeEventListener patterns. - WeakMap cache per callbackFn with auto-GC - Inner Map tracks useSignatureFrom variants
Implements iterable weak collection types using WeakRef + FinalizationRegistry, enabling safe cleanup of connection-bound callbacks without memory leaks. These classes solve the issue where ClientCallbacks/ClientCallbacksForEntities need to be forgettable but also iterable - something the built-in WeakSet/WeakMap don't support and the not-so-weak package's implementation has correctness bugs. Implementation details: - Uses WeakRef to hold weak references to values/keys - Uses FinalizationRegistry to detect when entries are GC'd - Automatically compacts internal storage during iteration - Fully typed with proper TypeScript generics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
withTrim currently creates a new wrapper function on every call, making it incompatible with addEventListener/removeEventListener patterns that rely on reference identity. This PR adds a WeakMap-based cache that reuses the same wrapper for identical (callbackFn, useSignatureFrom) pairs.
Changes
withTrimCacheWeakMap to cache wrapper functions per callbackFnCloses #8