Supply-chain audit: busboy is safe + multipart upload handler#14
Open
onchito-walks wants to merge 1 commit into
Open
Supply-chain audit: busboy is safe + multipart upload handler#14onchito-walks wants to merge 1 commit into
onchito-walks wants to merge 1 commit into
Conversation
- Added comprehensive supply-chain security audit of busboy (audits/busboy-supply-chain-audit.md) - Implemented multipart/form-data file upload handling with safety limits: - 50MB max file size, 10 max files, 100 max parts, 1MB max field - 30-second timeout to prevent resource exhaustion - Proper streaming with backpressure - Busboy is confirmed side-effect-free with zero runtime dependencies Closes bogeeee#6
|
👀 We've notified the reward creators here. |
Author
|
Hey, just checking if you've had a chance to look at this. Happy to make any adjustments. |
Author
|
Bumping this — any feedback when you get a moment? Still happy to iterate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #6
What
Why
The existing code threw "not yet implemented" for multipart uploads. This PR enables them safely.
Changes
audits/busboy-supply-chain-audit.md— full audit reportserver/ServerSession.ts— multipart handler with limits (50MB filesize, 10 files, 100 parts, 30s timeout)