Skip to content

Git functionality in BLIH#2

Open
am0ka wants to merge 7 commits intobocal:masterfrom
am0ka:master
Open

Git functionality in BLIH#2
am0ka wants to merge 7 commits intobocal:masterfrom
am0ka:master

Conversation

@am0ka
Copy link

@am0ka am0ka commented Sep 30, 2018

Dear Emmanuel Vadot,
I have sent you an email (elbarto@bocal.org). Could you read please?

@Tina-otoge
Copy link

Tina-otoge commented Oct 2, 2018

I don't think the blih push feature is well designed.

Adding all files to a commit is very bad practice, also only allowing pushes to origin/master is very limiting, and there's nothing related to EPITECH in this implementation.

I think something that searches for the registered remotes and find one that matches the URL of EPITECH's git server (write that as a constant at the top of file) would be way more useful, instead of only allowing the remote named origin.

Also please only push to the currently selected branch and not master. Even better implementation would be to use the behavior defined in gitconfig for push.default (see https://git-scm.com/docs/git-config#git-config-pushdefault for reference)

@am0ka
Copy link
Author

am0ka commented Oct 2, 2018 via email

@am0ka
Copy link
Author

am0ka commented Oct 7, 2018

I found that it is hard to use current source code, which is in bocal/blih:master, so I made a new repository, where I used v1.7 as the base. [https://github.com/am0ka/blih-modification](Modified BLIH)

After some time of discussing with other students of Epitech, whether is blih push instead of git push necessary, I have concluded that blih clone is the only useful function.
Apart from it, I found, that realization of option --token is not used widely, because many students don't even know how to use it. I have changed it to take not sha512 hash, but the user's password and convert it into the hash.

My intentions is not to offend you or your team. I just wanted to have some real practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants