Incorporated interface_driver into ethtool for puppet 4 support#20
Open
enemarke wants to merge 4 commits intobobtfish:masterfrom
Open
Incorporated interface_driver into ethtool for puppet 4 support#20enemarke wants to merge 4 commits intobobtfish:masterfrom
enemarke wants to merge 4 commits intobobtfish:masterfrom
Conversation
Contributor
Author
|
So travis fails with ruby version 1.9.3. My Ruby foo is only good enough to make it work by removing ruby 1.9.3 support from the module and make a new version that only supports puppet 4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facter/utils/ip is no longer supported in facter 3.x which is shipped with puppet 4. If you accept these changes, could you make a new release of the module to have it available from forge.puppet.com?
If you need any help preparing the module for a new release please let me know and I will gladly help updating documentation etc.