Skip to content

🛡️ Sentinel: [MEDIUM] Fix physical exposure of sensitive credentials#96

Open
bobdivx wants to merge 1 commit into
devfrom
sentinel-fix-physical-credential-exposure-13795378355631650782
Open

🛡️ Sentinel: [MEDIUM] Fix physical exposure of sensitive credentials#96
bobdivx wants to merge 1 commit into
devfrom
sentinel-fix-physical-credential-exposure-13795378355631650782

Conversation

@bobdivx
Copy link
Copy Markdown
Owner

@bobdivx bobdivx commented May 30, 2026

🚨 Severity: MEDIUM
💡 Vulnerability: Sensitive credentials like TMDB API keys, Tracker Passkeys, and Custom Indexer API keys were exposed in plaintext using <input type="text">. This allowed for physical security breaches such as shoulder-surfing or unintentional exposure via browser autofill leakage.
🎯 Impact: An attacker with physical proximity or a malicious script accessing browser autofill could capture high-value API keys and passkeys, potentially leading to unauthorized access to the user's external services.
🔧 Fix: Changed the type attribute from "text" to "password" and added autoComplete="off" for all sensitive credential inputs in TmdbConfig, TmdbStep, UploadAssistantPanel, UploadTrackersManagerPanel, and UploadTrackerPanel. Also documented this physical exposure vector in the Sentinel journal.
Verification: Verified the UI changes locally, confirmed that passwords are now masked by default, and ensured that the frontend builds and unit tests pass successfully.


PR created automatically by Jules for task 13795378355631650782 started by @bobdivx

Changes input types from "text" to "password" and adds "autoComplete=off" for sensitive credentials like TMDB API Keys and Tracker Passkeys to prevent shoulder-surfing and browser autofill leakage.

Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
popcorn-client Ready Ready Preview, Comment May 30, 2026 6:28am

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enhances security by masking sensitive input fields (such as TMDB API keys and tracker passkeys) using type="password" and autoComplete="off", and documents this security standard in the sentinel journal. The reviewer suggests using autoComplete="new-password" instead of autoComplete="off" across all updated components and the sentinel journal, as modern browsers often ignore off for password inputs to support password managers.

Comment on lines +207 to +208
type="password"
autoComplete="off"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Modern browsers (such as Chrome, Firefox, and Safari) often ignore autoComplete="off" on type="password" inputs to ensure that password managers can still function. To reliably prevent the browser from autofilling or suggesting saved credentials in non-login sensitive fields (like API keys or passkeys), it is highly recommended to use autoComplete="new-password" instead.

Suggested change
type="password"
autoComplete="off"
type="password"
autoComplete="new-password"

Comment on lines +1681 to +1682
type="password"
autoComplete="off"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Modern browsers often ignore autoComplete="off" on type="password" inputs. To reliably prevent browser autofill on sensitive fields that are not standard login passwords (such as API keys or passkeys), use autoComplete="new-password" instead.

Suggested change
type="password"
autoComplete="off"
type="password"
autoComplete="new-password"

Comment on lines +1698 to +1699
type="password"
autoComplete="off"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Modern browsers often ignore autoComplete="off" on type="password" inputs. To reliably prevent browser autofill on sensitive fields that are not standard login passwords (such as API keys or passkeys), use autoComplete="new-password" instead.

Suggested change
type="password"
autoComplete="off"
type="password"
autoComplete="new-password"

Comment on lines +323 to +324
type="password"
autoComplete="off"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Modern browsers often ignore autoComplete="off" on type="password" inputs. To reliably prevent browser autofill on sensitive fields that are not standard login passwords (such as API keys or passkeys), use autoComplete="new-password" instead.

Suggested change
type="password"
autoComplete="off"
type="password"
autoComplete="new-password"

Comment on lines +272 to +273
type="password"
autoComplete="off"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Modern browsers often ignore autoComplete="off" on type="password" inputs. To reliably prevent browser autofill on sensitive fields that are not standard login passwords (such as API keys or passkeys), use autoComplete="new-password" instead.

Suggested change
type="password"
autoComplete="off"
type="password"
autoComplete="new-password"

Comment on lines +286 to +287
type="password"
autoComplete="off"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Modern browsers often ignore autoComplete="off" on type="password" inputs. To reliably prevent browser autofill on sensitive fields that are not standard login passwords (such as API keys or passkeys), use autoComplete="new-password" instead.

Suggested change
type="password"
autoComplete="off"
type="password"
autoComplete="new-password"

Comment on lines +299 to +300
type="password"
autoComplete="off"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

Modern browsers often ignore autoComplete="off" on type="password" inputs. To reliably prevent browser autofill on sensitive fields that are not standard login passwords (such as API keys or passkeys), use autoComplete="new-password" instead.

Suggested change
type="password"
autoComplete="off"
type="password"
autoComplete="new-password"

Comment thread .jules/sentinel.md
## 2026-05-30 - Prevent Physical Exposure of Sensitive Credentials
**Vulnerability:** Sensitive credentials like TMDB API keys, Tracker Passkeys, and Custom Indexer API keys were exposed using `<input type="text">`, allowing physical security breaches such as shoulder-surfing or browser autofill leakage.
**Learning:** Even in authenticated or local-first environments, high-value credentials must be masked by default because physical exposure is a valid attack vector. Relying on manually blurring or "hiding" text after entry is insufficient.
**Prevention:** Always use `<input type="password">` with `autoComplete="off"` for sensitive credentials in frontend components. If user visibility is needed during entry, provide a dedicated 'Show/Hide' toggle rather than defaulting to plaintext.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Update the prevention guidelines in the sentinel journal to recommend autoComplete="new-password" instead of autoComplete="off" for better alignment with modern browser behaviors regarding password inputs.

Suggested change
**Prevention:** Always use `<input type="password">` with `autoComplete="off"` for sensitive credentials in frontend components. If user visibility is needed during entry, provide a dedicated 'Show/Hide' toggle rather than defaulting to plaintext.
**Prevention:** Always use `<input type="password">` with `autoComplete="new-password"` for sensitive credentials in frontend components. If user visibility is needed during entry, provide a dedicated 'Show/Hide' toggle rather than defaulting to plaintext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant