🛡️ Sentinel: [HIGH] Fix sensitive credentials exposure in input fields#78
🛡️ Sentinel: [HIGH] Fix sensitive credentials exposure in input fields#78bobdivx wants to merge 1 commit into
Conversation
Replaces plain text inputs with password type inputs and disables auto-complete for API keys and passkeys to prevent shoulder surfing and auto-fill leaks. Co-authored-by: bobdivx <6737167+bobdivx@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances security by masking sensitive credentials, such as TMDB and C411 API keys and tracker passkeys, by changing input types from 'text' to 'password' and adding 'autoComplete="off"' across several configuration components. It also includes a documentation update in '.jules/sentinel.md' regarding these security practices and a minor path correction in '.astro/content.d.ts'. The reviewer suggests using 'autoComplete="new-password"' instead of '"off"' to more reliably prevent browser autofill and password-saving prompts, which are often triggered by password-type fields.
| <input | ||
| type="text" | ||
| type="password" | ||
| autoComplete="off" |
There was a problem hiding this comment.
While autoComplete="off" is a good start, modern browsers often ignore it for fields with type="password" to encourage the use of password managers. For sensitive fields like API keys that should not be saved as the site's login credentials, using autoComplete="new-password" is generally more effective at preventing browser autofill and "Save password?" prompts.
| autoComplete="off" | |
| autoComplete="new-password" |
| <input | ||
| type="text" | ||
| type="password" | ||
| autoComplete="off" |
There was a problem hiding this comment.
Consider using autoComplete="new-password" instead of "off". Modern browsers frequently ignore off for password-type inputs, whereas new-password is a stronger hint to disable autofill and prevent the browser from offering to save these credentials as the account password.
| autoComplete="off" | |
| autoComplete="new-password" |
| <input | ||
| type="text" | ||
| type="password" | ||
| autoComplete="off" |
There was a problem hiding this comment.
Consider using autoComplete="new-password" instead of "off". Modern browsers frequently ignore off for password-type inputs, whereas new-password is a stronger hint to disable autofill and prevent the browser from offering to save these credentials as the account password.
| autoComplete="off" | |
| autoComplete="new-password" |
| <input | ||
| type="text" | ||
| type="password" | ||
| autoComplete="off" |
There was a problem hiding this comment.
Consider using autoComplete="new-password" instead of "off". Modern browsers frequently ignore off for password-type inputs, whereas new-password is a stronger hint to disable autofill and prevent the browser from offering to save these credentials as the account password.
| autoComplete="off" | |
| autoComplete="new-password" |
| <input | ||
| type="text" | ||
| type="password" | ||
| autoComplete="off" |
There was a problem hiding this comment.
Consider using autoComplete="new-password" instead of "off". Modern browsers frequently ignore off for password-type inputs, whereas new-password is a stronger hint to disable autofill and prevent the browser from offering to save these credentials as the account password.
| autoComplete="off" | |
| autoComplete="new-password" |
| <input | ||
| type="text" | ||
| type="password" | ||
| autoComplete="off" |
There was a problem hiding this comment.
Consider using autoComplete="new-password" instead of "off". Modern browsers frequently ignore off for password-type inputs, whereas new-password is a stronger hint to disable autofill and prevent the browser from offering to save these credentials as the account password.
| autoComplete="off" | |
| autoComplete="new-password" |
| <input | ||
| type="text" | ||
| type="password" | ||
| autoComplete="off" |
There was a problem hiding this comment.
Consider using autoComplete="new-password" instead of "off". Modern browsers frequently ignore off for password-type inputs, whereas new-password is a stronger hint to disable autofill and prevent the browser from offering to save these credentials as the account password.
| autoComplete="off" | |
| autoComplete="new-password" |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: Sensitive credentials (TMDB API keys, C411 API keys, tracker passkeys) were being rendered in
<input type="text">fields across multiple settings panels, exposing them to shoulder-surfing and browser autofill/caching vulnerabilities.🎯 Impact: Potential leakage of user secrets leading to unauthorized access to their integrated services or tracker accounts.
🔧 Fix: Changed all identified sensitive credential input fields to use
<input type="password">combined withautoComplete="off".✅ Verification: Verified that building and testing pass successfully and that UI components now render the input values safely masked as password fields. Recorded learning in
.jules/sentinel.md.PR created automatically by Jules for task 18404683273273866353 started by @bobdivx