Skip to content

🛡️ Sentinel: [CRITICAL] Fix command injection in docker logs endpoint #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobdivx wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

🛡️ Sentinel: [CRITICAL] Fix command injection in docker logs endpoint #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
## 2024-05-24 - Command Injection Risk in docker logs endpoint
**Vulnerability:** Node.js `execSync` combined with unsanitized URL query parameters (`id` and `tail`) directly interpolated into a shell string caused a command injection vulnerability. Additionally, user-controlled flags were not validated.
**Learning:** Raw shell execution functions (like `execSync`) evaluate shell meta-characters. Interpolating user inputs into these functions exposes the application to remote code execution (RCE) and argument/flag injection.
**Prevention:**
1. Prefer `execFile` or `execFileAsync` where parameters are provided as an array so they are not evaluated by the shell.
2. Explicitly validate variables meant to be command arguments to ensure they do not start with hyphens (`-`) to avoid flag injection.
3. Separate executable targets and variables using double-dashes (`--`) if the command supports it.
Loading