Skip to content

Conversation

@immanuelazn
Copy link
Collaborator

@immanuelazn immanuelazn commented Jan 27, 2025

Meta-PR that describes the culmination of efforts of multiple features.

Included and previously described features:

@immanuelazn immanuelazn changed the title Normalization, feature selections, dimreduction S3 class, (iterative) lsi implementation, Partial function framework, clustering changes and framework Normalizations, Feature Selections, DimReduction S3 class, (Iterative) Lsi Implementation, Partial function framework, Clustering changes and Framework Feb 28, 2025
rewrite `convert_mat_to_cluster_matrix()` to always convert to graph adjacency matrix.
rename `convert_mat_to_cluster_matrix()` to `convert_mat_to_graph()`.
Add input checking for knn to graph functions
#' @param n_iterations (int) The number of LSI iterations to perform.
#' @param feature_selection_method (function) Method to use for selecting features for LSI.
#' Current builtin options are `select_features_variance`, `select_features_dispersion`, `select_features_mean`, `select_features_binned_dispersion`
#' @param cluster_method (function) Method to use for clustering the post-SVD matrix.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not too happy explicitly describing usage of partial functions here. Perhaps we can replace this once the test data is in, and we can show the small vignette with norms, feature selection, clustering + LSI. On top of that, we can just show usage directly with examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants