-
Notifications
You must be signed in to change notification settings - Fork 30
Normalizations, Feature Selections, DimReduction S3 class, (Iterative) Lsi Implementation, Partial function framework, Clustering changes and Framework #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
immanuelazn
wants to merge
149
commits into
bnprks:main
Choose a base branch
from
immanuelazn:ia/lsi-iterative
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`save_lsi`, remove `save_in_memory` in `lsi()`
rewrite `convert_mat_to_cluster_matrix()` to always convert to graph adjacency matrix. rename `convert_mat_to_cluster_matrix()` to `convert_mat_to_graph()`. Add input checking for knn to graph functions
immanuelazn
commented
Mar 3, 2025
| #' @param n_iterations (int) The number of LSI iterations to perform. | ||
| #' @param feature_selection_method (function) Method to use for selecting features for LSI. | ||
| #' Current builtin options are `select_features_variance`, `select_features_dispersion`, `select_features_mean`, `select_features_binned_dispersion` | ||
| #' @param cluster_method (function) Method to use for clustering the post-SVD matrix. |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not too happy explicitly describing usage of partial functions here. Perhaps we can replace this once the test data is in, and we can show the small vignette with norms, feature selection, clustering + LSI. On top of that, we can just show usage directly with examples.
1c9134e to
4016ddf
Compare
integrate `cluster_cells_graph()` into codebase
…k on IterativeLSI
export `cluster_cells_graph()`
a7c6fdb to
0dd291b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta-PR that describes the culmination of efforts of multiple features.
Included and previously described features: