Paypal #467
Open
Paypal #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his is part of their api.
…e created. Introduce new steps to set the oAuthHostDomain.
…s/current. Fix to pull that info
…as well as in the data params for oauth2 requests.
Everyauth lacks sane error handling. This allows us to redirect to a different path on error and not have problems with trying to send a response twice. Related https://github.com/Datahero/datahero-node/issues/419
…nalQueryParams in oauth2 related https://github.com/Datahero/datahero-node/issues/4328
…ectly resulting in leaks. Fixes https://github.com/Datahero/datahero-node/issues/4602
zendesk module merged from QL.
Zendesk oauth2 implementation (will most likely back out the oauth2 domain change into a configurable item in the zendesk module tomorrow)
…escribing what functionality should be tested further
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass attempt at Paypal integration. Current implementation successfully grabs authorization code, but request designed to get access token fails in PayPal sandbox with 500 error. Some suggestions written in as comments as to areas that may help mitigate this issue.